Enforce single PHP instance per CLI worker for correct file locking #2996
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When PHP acquires file locks via
flock(), the locks are managed at the kernel level per-process. Multiple PHP WASM instances within the same OS process would share those locks, defeating the purpose of file locking for concurrent access control.This PR ensures CLI workers use exactly one PHP instance by:
maxPhpInstancesoption toPHPRequestHandlerthat, when set to 1, bypassesPHPProcessManagerentirely and uses a single PHP instance directlycreatePhpSpawnHandler()that accepts a configurablephpCliHandlerfor subprocess spawningcreatePhpSpawnHandlerwithout a PHP CLI handler, meaningproc_open('php ...')returns exit code 127 instead of spawning in-processsandboxedSpawnHandlerFactorywhich spawns PHP instances viaPHPProcessManagerNew Spawn Handler API
Test plan
sandboxedSpawnHandlerFactorytests passproc_open('ls')works in CLIproc_open('php ...')returns exit code 127 in CLI