Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fine tune all search blocks #184

Closed
carolinan opened this issue Sep 3, 2024 · 1 comment · Fixed by #377
Closed

Fine tune all search blocks #184

carolinan opened this issue Sep 3, 2024 · 1 comment · Fixed by #377
Assignees
Labels
[Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@carolinan
Copy link
Contributor

carolinan commented Sep 3, 2024

Description
Currently the patterns that use search forms are using 3 different styles:

<!-- wp:search {"label":"Search","showLabel":false,"widthUnit":"%","buttonText":"Search","style":{"border":{"radius":"100px"}},"fontSize":"small","borderColor":"opacity-20"} /-->

<!-- wp:search {"label":"Search","showLabel":false,"buttonText":"Search","style":{"border":{"radius":"50px"}},"fontSize":"medium","borderColor":"opacity-20"} /-->

<!-- wp:search {"label":"Search","showLabel":false,"buttonText":"Search","style":{"border":{"radius":"50px"}},"fontSize":"medium"} /-->

Lets try to find a way to remove the border radius from the block markup, and make sure that the border radius and border color matches. This is needed because when we start adding the style variations, they need to be able to override the styles of the inputs. See for example: https://www.figma.com/design/dzGCSntVch4EQdVERTqyVK/Twenty-Twenty-Five?node-id=77-650&m=dev

Search form blocks that do not have a visible label, still needs the "label" attribute to contain the word "Search" and this should also be translation ready.

Two of the blocks uses font size medium and two uses font size small. The default font size in theme.json is medium,
so these blocks do not need the font size to be added in the pattern.

@carolinan carolinan added [Type] Enhancement A suggestion for improvement. [Status] Blocked Used to indicate that a current effort isn't able to move forward labels Sep 3, 2024
@carolinan
Copy link
Contributor Author

I found the following issue and pull request in the Twenty Twenty-Four repository:
WordPress/twentytwentyfour#389
https://github.com/WordPress/twentytwentyfour/pull/398/files

It shows a bug with the styling of the forms, that is still not solved.

@carolinan carolinan removed the [Status] Blocked Used to indicate that a current effort isn't able to move forward label Sep 16, 2024
@carolinan carolinan self-assigned this Sep 16, 2024
@carolinan carolinan added the [Status] In Progress Tracking issues with work in progress label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
1 participant