[Bug] Pot file generation runs on every git push and updates timestamp without other changes

[sarayourfriend]

Description

Any git push will run the pot file generation script which will always update the timestamp even if there are no other changes, causing a dirty git status after pushing.

Reproduction

1. Make a change on a branch with the latest main branch
2. Commit everything and git push successfully
3. Run git status and note the updated timestamp on the generated pot file

Expectation

Status should be clean, there should be no changes unless they block a git push

Additional context

I think this was caused by the changes that fixed pot file generation in #318

Resolution

• 🙋 I would be interested in resolving this bug.

[sarayourfriend]

cc @obulat who probably knows best how to fix this 🙂

[obulat]

I had some fun debugging this issue, @sarayourfriend :) We had the pot file generation helper functions, and the script creating the pot file in the top level in the same file. So, when husky was running npm run test during the pre-push checks, it was importing functions from the json-to-pot.js, and, as a side effect, running the createPotFile from it on every push.