Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(input): update disabled style #1336

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

chore(input): update disabled style #1336

wants to merge 19 commits into from

Conversation

RyushiAok
Copy link
Collaborator

タスク

resolve: #1330

@vercel Vercel
Copy link

vercel bot commented Jul 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wiz-ui-next ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 28, 2024 6:10pm
wiz-ui-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 28, 2024 6:10pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 2, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: c8a907d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@wizleap-inc/wiz-ui-react Minor
@wizleap-inc/wiz-ui-next Minor
@wizleap-inc/wiz-ui-styles Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the 🚧 wip Work In Progress label Jul 2, 2024
@RyushiAok RyushiAok changed the title chore(base-input): update disabled style chore(input): update disabled style Jul 2, 2024
@RyushiAok RyushiAok self-assigned this Jul 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 2, 2024 •
edited
Loading

Size Change: +622 B (+0.19%)

Total Size: 327 kB

Filename Size Change
./packages/wiz-ui-next/dist/style.css 11.9 kB +61 B (+0.51%)
./packages/wiz-ui-next/dist/wiz-ui.es.js 84.6 kB +419 B (+0.5%)
./packages/wiz-ui-next/dist/wiz-ui.umd.js 73.7 kB +79 B (+0.11%)
./packages/wiz-ui-react/dist/style.css 11.9 kB +63 B (+0.53%)
./packages/wiz-ui-react/dist/wiz-ui.es.js 77.2 kB -4 B (-0.01%)
./packages/wiz-ui-react/dist/wiz-ui.umd.js 67.9 kB +4 B (+0.01%)

compressed-size-action

@reg-suit reg-suit
Copy link

reg-suit bot commented Jul 2, 2024 •
edited
Loading

reg-suit detected visual differences.

Check this report, and review them.

🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴
⚪⚪⚪⚪⚪

🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵

What do the circles mean? The number of circles represent the number of changed images.
🔴 : Changed items, ⚪ : New items, ⚫ : Deleted items, and 🔵 Passed items

How can I change the check status? If reviewers approve this PR, the reg context status will be green automatically.

@RyushiAok RyushiAok requested a review from ichi-h July 3, 2024 08:46
@ichi-h
Copy link
Collaborator

ichi-h commented Jul 4, 2024

date-pickerとdate-range-pickerは何らかの日付を選択しているときにdisabledになると、バツボタンが消えるみたいなので注意です！
スクリーンショット 2024-07-04 17 32 18

ichi-h
ichi-h reviewed Jul 4, 2024
View reviewed changes
Copy link
Collaborator

@ichi-h ichi-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

何点かコメントがございますのでこちらをお願いいたします！

(vue) date-range-pickerのstoryのdisabledが効かない

image

search-input/selectorのdisabledについて

この2つはoptionを選択して、選択した要素がアイテムとして表示されているときのデザインもstoryに含めたいです！
disabledのstoryに未選択verと選択verをまとめて2つおいてしまって大丈夫だと思います！

textareaのdisabledのデザインが異なる

すみませんissueにtextareaが漏れていました……
こちらもお願いいたします…… 🙇

スクリーンショット 2024-07-04 17 44 27

@ichi-h
Copy link
Collaborator

ichi-h commented Jul 8, 2024

  • passwordがdisabledの時は、表示・非表示のbuttonもdisabled
  • passwordがdisabledになった時は、パスワードの中身を強制的にフラグの中身を強制的に非表示に書き換える

@ichi-h
Copy link
Collaborator

ichi-h commented Jul 11, 2024

changesetの追加お願いいたします！

@k-tada k-tada self-requested a review August 19, 2024 01:26
@ichi-h ichi-h added 🛑 pending 停止中 and removed 🚧 wip Work In Progress labels Aug 26, 2024
k-tada
k-tada approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@k-tada k-tada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ichi-h ichi-h ichi-h left review comments

@k-tada k-tada k-tada approved these changes

Assignees

@RyushiAok RyushiAok

Labels
🛑 pending 停止中
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat(disabledを持つコンポーネント全般): disabled時の文字の色を調整する
3 participants
@RyushiAok @ichi-h @k-tada