Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interrupting benchmark run persists partial cache file #16

Open
FiloSottile opened this issue Sep 22, 2021 · 2 comments
Open

Interrupting benchmark run persists partial cache file #16

FiloSottile opened this issue Sep 22, 2021 · 2 comments

Comments

@FiloSottile
Copy link
Contributor

I stated a benchdiff run, and then realized I had gotten it wrong and stopped it with ^C.

When I reran it, it said "skipping benchmark for ref "HEAD^" because output file exists" although the file in the cache was just a couple lines from the first benchmark.

Instead, the output should go to a temporary file and only get moved to the cache upon success.

@FiloSottile
Copy link
Contributor Author

Relatedly, interrupting a run also leaves behind a git worktree. It would be nice if the signal was caught and a cleanup step run anyway.

@WillAbides
Copy link
Owner

Thanks. I haven't run across this before, probably because I typically use --force-base.

The next few weeks are busy for me, so I don't think I will have time to get to this for a while. If you can identify a fix, I can make time for a PR review. Otherwise it may be a while before this is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants