Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent frequency suffixes: some have 'ly', others do not #35

Open
deoren opened this issue Apr 1, 2019 · 0 comments
Open

Inconsistent frequency suffixes: some have 'ly', others do not #35

deoren opened this issue Apr 1, 2019 · 0 comments

Comments

@deoren
Copy link
Collaborator

deoren commented Apr 1, 2019

For example, here are the current keywords:

DATE_LABEL = {
    'daily':TODAY,
    'twice_week':TODAY,
    'weekly':TODAY,
    'weekly_monday':TODAY,
    'weekly_tuesday':TODAY,
    'weekly_wednesday':TODAY,
    'weekly_thursday':TODAY,
    'weekly_friday':TODAY,
    'weekly_saturday':TODAY,
    'weekly_sunday':TODAY,
    'twice_month':TODAY,
    'monthly':MONTH_YEAR,
    'twice_year':MONTH_YEAR,
    'quarterly':MONTH_YEAR,
    'yearly':YEAR
}

We have weekly, and twice_week instead of twice_weekly.

Not sure we should support pattern matching in order to satisfy a requirement, but it would probably be useful to have a small hash with aliases for common items.

An alternative is to adjust all entries to use consist ly suffixes. This might be the best approach in the long run.

@deoren deoren added this to the Future milestone Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant