Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

should we remove the object from this.children ? #376

Open
BrookShuihuaLee opened this issue Apr 24, 2018 · 7 comments
Open

should we remove the object from this.children ? #376

BrookShuihuaLee opened this issue Apr 24, 2018 · 7 comments
Assignees
@sasha240100
Labels
QUESTION

Comments

@BrookShuihuaLee
Copy link
Contributor

whs.js/src/modules/app/SceneModule.js

Line 47 in 591f4b4

this.remove = function (object) {

@BrookShuihuaLee
Copy link
Contributor Author

i find that the element in app.children will never be removed. is this a bug?

@BrookShuihuaLee
Copy link
Contributor Author

@hirako2000

@hirako2000
Copy link
Collaborator

Good question, I don't tend to use children; @sasha240100 would answer you.

@BrookShuihuaLee
Copy link
Contributor Author

thank you @hirako2000 . so, do you think this is a bug ? @sasha240100

@BrookShuihuaLee
Copy link
Contributor Author

same as

whs.js/src/core/Component.js

Line 181 in 591f4b4

remove(object) {

@sasha240100
Copy link
Member

@BrookShuihuaLee A bug, true. Really thankful that you found it! Would be glad to see a PR from you:)

@BrookShuihuaLee
Copy link
Contributor Author

ok, i'll try it later.

@BrookShuihuaLee BrookShuihuaLee mentioned this issue Apr 25, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sasha240100 sasha240100

Labels
QUESTION
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hirako2000 @sasha240100 @BrookShuihuaLee