Travis CI examples deployment isn't working

[sasha240100]

Travis CI examples deployment isn't working.

Version:

• v2.x.x
• v1.x.x

Issue type:

• Bug
• Proposal/Enhancement
• Question
• Discussion

---

Tested on:

Desktop

• Chrome
• Chrome Canary
• Chrome dev-channel
• Firefox
• Opera
• Microsoft IE
• Microsoft Edge

Android

• Chrome
• Firefox
• Opera

IOS

• Chrome
• Firefox
• Opera

[hirako2000]

has it ever worked automatically? I don't see the deploy step for examples.
I see two surge steps. Does not look like they are for pushing examples.

before_deploy:
  - gulp examples:build
  - gulp docs --all
...
deploy:
  provider: surge
  project: ./
  domain: whs-dev.surge.sh
  skip_cleanup: true
  on: dev
deploy:
  provider: surge
  project: ./docs/public/
  domain: whsjs.io
  skip_cleanup: true
  on:
    branch: master
    tags: true

[hirako2000]

Also, I propose we do this as part of this issue:

• Add another surge deploy step for examples, to build example that match latest released version of whs

deploy:
  provider: surge
  project: ./examples
  domain: whs-master.surge.sh
  skip_cleanup: true
  on: master

Otherwise some newer examples not supported yet by released version might be tried and would not work on the pulled dependency by users. would be confusing.

[sasha240100]

@hirako2000 I completely agree on that why. I still can't figure out why dev examples are not pushing to surge. (something happened, while nothing was touched)

[hirako2000]

this is a change, it was touched. maybe we can't have multiple deploy steps with same provider: diff.

I suggest we do this below, as documented here, and using Travis env variables for conditional branch deployment.

after_success:
  - test $TRAVIS_BRANCH = "dev" && surge --project ./ --domain whs-dev.surge.sh
  - test $TRAVIS_BRANCH = "master" && surge --project ./ --domain whs-master.surge.sh
  - test $TRAVIS_BRANCH = "master" && surge --project ./docs/public/ --domain whsjs.io