Skip to content
This repository has been archived by the owner on Mar 3, 2022. It is now read-only.

Broken Patterns #16

Open
sqram opened this issue Oct 11, 2013 · 0 comments
Open

Broken Patterns #16

sqram opened this issue Oct 11, 2013 · 0 comments

Comments

@sqram
Copy link

sqram commented Oct 11, 2013

Members of the House and Senate classes are too private. I suggest making them public so other classes can access and change them if needed. Furthermore, their deconstructor method should also be made public.

As a bonus improvement, since both classes above break the Singleton pattern by extending their parent Congress, the Congress class should no longer be a Singleton.

Willing to fork project, but don't have the time to commit. Will still contribute to it by placing votes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant