Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beta parameter is ignored in GPVAE when using the IWAE setting #540

Open
2 tasks
AlexandreAbraham opened this issue Oct 29, 2024 · 1 comment
Open
2 tasks
Labels
question Further information is requested

Comments

@AlexandreAbraham
Copy link

Issue description

In the backbone of GPVAE, a different path is taken depending on whether IWAE is used or not.

In the case K=1, the elbo is updated like this:

elbo = -nll - self.beta * kl

In the case K>1, the elbo is updated like that:

elbo = -nll - kl

I understand that those usages are different, but it feels wrong to me to silently ignore a parameter. Also, I do not see why beta could not be applied in the IWAE case. I therefore suggest one of:

  • Raise a warning if K is set >1 and Beta is specified by the user to avoid misunderstanding
  • Change the IWAE loss to be computer as the beta-VAE one.

Let me know so I can propose a PR.

Thanks for the great software!

@AlexandreAbraham AlexandreAbraham added the question Further information is requested label Oct 29, 2024
Copy link

Hi there 👋,

Thank you so much for your attention to PyPOTS! You can follow me on GitHub
to receive the latest news of PyPOTS. If you find PyPOTS helpful to your work, please star⭐️ this repository.
Your star is your recognition, which can help more people notice PyPOTS and grow PyPOTS community.
It matters and is definitely a kind of contribution to the community.

I have received your message and will respond ASAP. Thank you for your patience! 😃

Best,
Wenjie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant