Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CWD Tilde handling #287

Open
vyeevani opened this issue Sep 5, 2021 · 5 comments · May be fixed by #288
Open

CWD Tilde handling #287

vyeevani opened this issue Sep 5, 2021 · 5 comments · May be fixed by #288

Comments

@vyeevani
Copy link

vyeevani commented Sep 5, 2021

Not sure if this is necessary a feature or just a fix for some so I'll classify it as a feature for now. Fail to find "lldb-mi" when the cwd has a "~" expansion in it.

@vyeevani
Copy link
Author

vyeevani commented Sep 6, 2021

According to this, the child process developers rejected handling cwd tilde expansion so it would have to be handled inside this repo: nodejs/node#684

@GitMensch
Copy link
Collaborator

GitMensch commented Sep 6, 2021

The feature implementation like that sounds easy:

cwd = cwd.replace(/^~/, os.homedir());

But I think this then may also be applied not to cwd, but also to the program and gdb/lldb executable and the argument list - if those don't work already.

@vyeevani
Copy link
Author

vyeevani commented Sep 6, 2021

I’ve made this PR to resolve this with untildify so that the support isn’t hard coded here as a string replacement. #288

@vyeevani
Copy link
Author

vyeevani commented Sep 7, 2021

@GitMensch do you happen to have write access to get this merged?

@GitMensch
Copy link
Collaborator

@vyeevani yes, but I won't do it now as @WebFreak001 had more or less the same questions that I had, please see the PR comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants