seedless onboarding password sync#6
Closed
tuna1207 wants to merge 40 commits intofeat/seedless-multi-srpfrom
Closed
seedless onboarding password sync#6tuna1207 wants to merge 40 commits intofeat/seedless-multi-srpfrom
tuna1207 wants to merge 40 commits intofeat/seedless-multi-srpfrom
Conversation
e6e424b to
60cff9b
Compare
…d-sync' into feat/seedless-onboarding-password-sync
lwin-kyaw
reviewed
Apr 25, 2025
packages/seedless-onboarding-controller/src/SeedlessOnboardingController.ts
Outdated
Show resolved
Hide resolved
lwin-kyaw
reviewed
Apr 25, 2025
lwin-kyaw
reviewed
Apr 25, 2025
packages/seedless-onboarding-controller/src/SeedlessOnboardingController.ts
Outdated
Show resolved
Hide resolved
lwin-kyaw
reviewed
Apr 25, 2025
packages/seedless-onboarding-controller/src/SeedlessOnboardingController.ts
Show resolved
Hide resolved
lwin-kyaw
reviewed
Apr 25, 2025
packages/seedless-onboarding-controller/src/SeedlessOnboardingController.ts
Outdated
Show resolved
Hide resolved
lwin-kyaw
reviewed
Apr 25, 2025
packages/seedless-onboarding-controller/src/SeedlessOnboardingController.ts
Outdated
Show resolved
Hide resolved
lwin-kyaw
reviewed
Apr 25, 2025
packages/seedless-onboarding-controller/src/SeedlessOnboardingController.ts
Outdated
Show resolved
Hide resolved
|
lgtm. |
…dless-onboarding-password-sync
himanshuchawla009
requested changes
Apr 29, 2025
Member
himanshuchawla009
left a comment
There was a problem hiding this comment.
good job, minor comments
packages/seedless-onboarding-controller/src/SeedlessOnboardingController.ts
Show resolved
Hide resolved
packages/seedless-onboarding-controller/src/SeedlessOnboardingController.ts
Outdated
Show resolved
Hide resolved
packages/seedless-onboarding-controller/src/SeedlessOnboardingController.ts
Outdated
Show resolved
Hide resolved
packages/seedless-onboarding-controller/src/SeedlessOnboardingController.ts
Outdated
Show resolved
Hide resolved
packages/seedless-onboarding-controller/src/SeedlessOnboardingController.ts
Outdated
Show resolved
Hide resolved
packages/seedless-onboarding-controller/src/SeedlessOnboardingController.ts
Outdated
Show resolved
Hide resolved
packages/seedless-onboarding-controller/src/SeedlessOnboardingController.ts
Show resolved
Hide resolved
packages/seedless-onboarding-controller/src/SeedlessOnboardingController.ts
Outdated
Show resolved
Hide resolved
packages/seedless-onboarding-controller/src/SeedlessOnboardingController.ts
Outdated
Show resolved
Hide resolved
packages/seedless-onboarding-controller/src/SeedlessOnboardingController.ts
Show resolved
Hide resolved
packages/seedless-onboarding-controller/src/SeedlessOnboardingController.ts
Show resolved
Hide resolved
packages/seedless-onboarding-controller/src/SeedlessOnboardingController.ts
Outdated
Show resolved
Hide resolved
d7c3553 to
9cf2022
Compare
packages/seedless-onboarding-controller/src/SeedlessOnboardingController.ts
Outdated
Show resolved
Hide resolved
packages/seedless-onboarding-controller/src/SeedlessOnboardingController.ts
Show resolved
Hide resolved
packages/seedless-onboarding-controller/toprf-secure-backup.tgz
Outdated
Show resolved
Hide resolved
matthiasgeihs
previously requested changes
May 16, 2025
packages/seedless-onboarding-controller/src/SeedlessOnboardingController.test.ts
Show resolved
Hide resolved
…d-sync' into feat/seedless-onboarding-password-sync
matthiasgeihs
left a comment
There was a problem hiding this comment.
Almost good to go. Just need to add link to PR to make change log checker happy. See here.
matthiasgeihs
left a comment
There was a problem hiding this comment.
review comments have been addressed except for removing the .tgz file. i presume it needs to be there until a more recent version has been published? not sure if you wanna remove it before merging the PR into the feature branch, or only when the feature branch is ready.
…at/seedless-onboarding-password-sync
…d-sync' into feat/seedless-onboarding-password-sync
…at/seedless-onboarding-password-sync
16a7712 to
235e255
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Handle password sync flow
References
https://docs.google.com/document/d/1r7WwVgrdmBLzhX7yYDrVc-NEs_Q02VPBGXi2-VGQAyc/edit?tab=t.0
Changelog
Checklist