-
Notifications
You must be signed in to change notification settings - Fork 57
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove "@react-native-async-storage/async-storage" dependency #164
Comments
Hey @nlnw, this dep is defined as peer and only downloaded in dev mode https://github.com/WalletConnect/walletconnect-utils/blob/master/misc/keyvaluestorage/package.json#L51 It shouldn't be present in prod builds. |
It's not present in the final bundle, but it's still a waste to make all developers download this giant dependency, especially since it's not even used (the next largest dependency is 10x smaller). I mostly pick this up through viem. You can see how big that dependency is through this tool: https://pkg-size.dev/viem |
This dependency adds 200MB to npm installs because it also pulls in react-native. It's more than 10x bigger than any other dependency. This makes anything that uses walletconnect as a package need 500mb+ in wasted storage. Can you please find a way to include this type of dependency without pulling in this package which pulls in react-native unecessarily?
The text was updated successfully, but these errors were encountered: