-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OR string and email subject translations are missing #19
Labels
enhancement
New feature or request
Comments
Thanks for reporting. If you are a developer you can definitely submit a pull request in this repository. Otherwise, We will make all the strings as translation ready. |
Thanks for the reply and glad that this will be improved upon. I'm not that
familiar about github and pull requests yet so would be awesome If your
team can handle this 🙌
Thanks already 🤗
pe 17. maalisk. 2023 klo 9.48 Shahjahan Jewel ***@***.***>
kirjoitti:
… Thanks for reporting. If you are a developer you can definitely submit a
pull request in this repository. Otherwise, We will make all the strings as
translation ready.
—
Reply to this email directly, view it on GitHub
<#19 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A5IZ27MDX7BO2P3UEDYC67DW4QJMXANCNFSM6AAAAAAV6FEPZY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Hey @techjewel Since this is still open i noticed another string: It is translatable in the files but the actual translation doesn't seem to be working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hey there,
Cool plugin btw! I noticed that the string OR isn’t translating at the first stage of the process in login (Before hitting the login via magic url) but it translates after you have pressed the (login via magic url).
It also seems that the “Sign in to” string is missing from that should translate the subject of the email.
Found couple others in the emails:
String: Sign in to %s (The button)
String: If you did not make this request, you can safely ignore this email.
String: This email has been sent from:
Could you add these for the translation strings?
I have posted about these bugs in the WordPress forums also 2 months ago that can be found here: https://wordpress.org/support/topic/or-string-and-email-subject-translations-are-missing/ (That you could easily tick off also when the strings are added :D)
The text was updated successfully, but these errors were encountered: