-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DLC Generation - Refactor and New Cases #308
Conversation
Turn off generator at shutdown_time Expand default options Include wave_mod Apply PSF Catch error in first generic_case_input Only apply ICs in operational DLCs
…_RefactorCaseInputs
…_RefactorCaseInputs
I think this is ready to merge into I added some developer documentation to explain the new functions a bit. Please let me know if there's anything unclear. I have a set up on kestrel with all the DLCs that we could use a test. Running all the cases fully and actually checking them is probably too heavy for CI. I did a pretty thorough verification against our original DLC generator, and the results are attached in the post for this PR. I'm happy to go through this with anyone that uses the DLC generator heavily. |
…_RefactorCaseInputs
Following our in-person code review today, I think we are okay to merge this once tests pass. I updated the AEP TI calculation here: WEIS/weis/dlc_driver/dlc_generator.py Line 410 in eeeae10
Some future wish list items:
|
Purpose
Refactor and expand the DLC generator to follow the case input structure commonly used in aeroelasticse.
Major changes:
WEIS/weis/dlc_driver/dlc_generator.py
Line 607 in 3a1fd3d
DLC1.1_0_weis_job_00.fst
). I'm open to feedback from the stakeholders here.Minor changes:
write_stdout
) for writing individual OpenFAST outputs to text filesTo verify we are reproducing the functionality of the previous DLC driver, we compared the old simulations (blue) versus the new (red):
weis_dlc_verification1.pdf
weis_dlc_verification2.pdf
I think the differences that exist are acceptable, including
Type of change
What types of change is it?
Select the appropriate type(s) that describe this PR
Testing
The previous test_DLC_generator.py still applies.
Example 05 tests all the land-based DLCs.
Checklist
Put an
x
in the boxes that apply.