Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DLC Generation - Refactor and New Cases #308

Merged
merged 94 commits into from
Dec 12, 2024
Merged

Conversation

dzalkind
Copy link
Collaborator

@dzalkind dzalkind commented Aug 7, 2024

Purpose

Refactor and expand the DLC generator to follow the case input structure commonly used in aeroelasticse.

Major changes:

Minor changes:

  • Add modeling option (write_stdout) for writing individual OpenFAST outputs to text files

To verify we are reproducing the functionality of the previous DLC driver, we compared the old simulations (blue) versus the new (red):
weis_dlc_verification1.pdf

weis_dlc_verification2.pdf

I think the differences that exist are acceptable, including

  • Could not get a perfect match of the wave seeds in DLCs 1.4 and 1.5
  • Disabling unsteady aero in DLC 1.4 by default now, resulting in cleaner simulations
  • Slight difference in IEA-15 hub height used to generate DLC 1.5 winds
  • DLC 5.1 is now a proper emergency shut down, where GenTq drops to 0 at the shutdown time

Type of change

What types of change is it?
Select the appropriate type(s) that describe this PR

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

The previous test_DLC_generator.py still applies.

Example 05 tests all the land-based DLCs.

Checklist

Put an x in the boxes that apply.

  • I have run existing tests which pass locally with my changes
  • I have added new tests or examples that prove my fix is effective or that my feature works
  • I have added necessary documentation

abhineet-gupta and others added 30 commits April 10, 2024 09:52
Turn off generator at shutdown_time
Expand default options
Include wave_mod
Apply PSF
Catch error in first generic_case_input
Only apply ICs in operational DLCs
@dzalkind dzalkind changed the base branch from main to develop November 7, 2024 22:34
@dzalkind dzalkind marked this pull request as ready for review November 20, 2024 16:17
@dzalkind
Copy link
Collaborator Author

I think this is ready to merge into develop. I'd do that after we merge develop into main so this can be exercised a bit before releasing.

I added some developer documentation to explain the new functions a bit. Please let me know if there's anything unclear.

I have a set up on kestrel with all the DLCs that we could use a test. Running all the cases fully and actually checking them is probably too heavy for CI. I did a pretty thorough verification against our original DLC generator, and the results are attached in the post for this PR. I'm happy to go through this with anyone that uses the DLC generator heavily.

@dzalkind
Copy link
Collaborator Author

Following our in-person code review today, I think we are okay to merge this once tests pass.

I updated the AEP TI calculation here:

idlc.IECturbc = self.IECturb.NTM(idlc.URef) * dlc_options['TI_factor'] / idlc.URef * 100

Some future wish list items:

  • Making the seeds serial in integer order
  • Adding a PSF table
  • An example/configuration for generating the inputs without running

@dzalkind dzalkind merged commit eedc910 into develop Dec 12, 2024
36 checks passed
@dzalkind dzalkind deleted the DLC_RefactorCaseInputs branch December 12, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants