Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update mrapp for cleanup and garbage collection #669

Draft
wants to merge 11 commits into
base: sub-main
Choose a base branch
from
Draft

update mrapp for cleanup and garbage collection #669

wants to merge 11 commits into from

Conversation

hanbollar
Copy link
Contributor

@hanbollar hanbollar commented May 18, 2024 •
edited
Loading

Linking

Related to #677
Fixes #678

Problem

Description of the problem including potential code and/or screenshots as an example

Solution

Quick explanation of change to be done

Breaking Change

If this is a breaking change describe the before and after and why the change was necessary

Required to Merge

  • PASS - all necessary actions must pass (excluding the auto-skipped ones)
  • TEST IN HEADSET - main dev-testing-example and any of the other examples still work as expected
  • [ ] VIDEO - if this pr changes something visually - post a video here of it in headset-MR and/or on desktop (depending on what it affects) for the reviewer to reference.
  • TITLE - make sure the pr's title is updated appropriately as it will be used to name the commit on merge
  • [ ] BREAKING CHANGE
    • DOCUMENTATION: This includes any changes to html tags and their components
      • make a pr in the documentation repo that updates the manual docs to match the breaking change
      • link the pr of the documentation repo here: #pr
      • that pr must be approved by @lobau
    • SAMPLES/INDEX.HTML: This includes any changes (html tags or otherwise) that must be done to our landing page submodule as an effect of this pr's updates
      • make a pr in the mrjs landing page repo that updates the landing page to match the breaking change
      • link the pr of the landing page repo here: #pr
      • that pr must be approved by @hanbollar

@render Render
Copy link

render bot commented May 18, 2024

Your Render PR Server URL is https://examples-mrjs-pr-669.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-cp40soe3e1ms73choh2g.

@hanbollar hanbollar mentioned this pull request May 18, 2024
Merged
3 tasks
@hanbollar hanbollar changed the base branch from main to sub-main May 20, 2024 18:02
@hanbollar hanbollar changed the title WIP - Hb garbage collect update mrapp for cleanup and garbage collection May 22, 2024
@hanbollar
update for documentation
9a333ac 
Signed-off-by: hanbollar <[email protected]>
@hanbollar
add cleaner destructor
0f6476c 
Signed-off-by: hanbollar <[email protected]>
@hanbollar
update
def109b 
Signed-off-by: hanbollar <[email protected]>
@hanbollar
Copy link
Contributor Author

need to fix 'enter/exit' MR issue - otherwise it's ready to go

@hanbollar hanbollar changed the base branch from sub-main to main May 23, 2024 16:28
@hanbollar
Copy link
Contributor Author

swapping this back to main since it's not part of the major 'breaking-changes' refactor

@hanbollar
Copy link
Contributor Author

cant swap - should keep sub-main as itself and then merge that in after this pr since that's still before the big refactor / breaking change

@hanbollar hanbollar changed the base branch from main to sub-main May 23, 2024 16:31
@hanbollar
Copy link
Contributor Author

since we're paused and this is really outdated - turning this into a draft for viewing, but we'll prob redo this / not need this in a bit

@hanbollar hanbollar marked this pull request as draft July 22, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mrapp cleanup
1 participant
@hanbollar