Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Albums: Overhaul of "tracks" tab on album edit page #1872

Open
1 task done
saturclay opened this issue Dec 29, 2024 · 1 comment
Open
1 task done

Albums: Overhaul of "tracks" tab on album edit page #1872

saturclay opened this issue Dec 29, 2024 · 1 comment
Labels
complexity: unknown Unknown days of work content: albums Album entries content: songs Song entries feature request priority: low Issues/Tasks that are not so important

Comments

@saturclay
Copy link
Contributor

Is your feature request related to a problem? Please describe.

The process for adding songs to album is clunky and could use improvements.

  1. Creating a new song automatically adds the song title to the "alias" field instead of one of the "primary name" fields. If a primary name is required (and not having one brings up a validation warning see Multiple entries: New validation warnings #1481), then this necessitates moving the name to the primary name field when editing the song individually. We already have the ability to auto-detect language when adding lyrics, so perhaps that could be extended to song titles to detect whether they're English or not.
  2. The song search when searching for a track to add can be very slow. This isn't a huge issue when adding an existing song, since you can put the name in quotes, but this can make adding new songs or custom tracks difficult, particularly those with short or common names. Perhaps a solution would be a dedicated "new track" (and "new custom track") button that creates an unnamed track that you can then add a name to on the tracks tab.

Checklist (required)

Fill out the checklist.

@riipah
Copy link
Member

riipah commented Dec 29, 2024

  1. The library I used before for detecting language reported the confidence (in percentage), so that could be used here. If confidence is >90% that the language is English, then use that.
  2. That could be a workaround... IMO it would make the UX worse, so the real fix is improving search performance (using full text search such as Elastic probably, don't know what happened to the issue).

As another workaround, could there also be option to create custom track using quotes? The search would be faster. I guess currently it would include the quotes as part of the name, which is undesirable most of the time, but it could also strip those out automatically, or provide another option to add the song without the quotes.

@andreoda andreoda added content: songs Song entries content: albums Album entries labels Jan 6, 2025
@andreoda andreoda added priority: low Issues/Tasks that are not so important complexity: unknown Unknown days of work labels Jan 6, 2025
@andreoda andreoda changed the title [Feature request] Overhaul of "tracks" tab on album edit page Albums: Overhaul of "tracks" tab on album edit page Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity: unknown Unknown days of work content: albums Album entries content: songs Song entries feature request priority: low Issues/Tasks that are not so important
Projects
Development

No branches or pull requests

3 participants