Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor findin/isin/etc... #325

Open
andyneff opened this issue Jan 12, 2021 · 2 comments
Open

Refactor findin/isin/etc... #325

andyneff opened this issue Jan 12, 2021 · 2 comments

Comments

@andyneff
Copy link
Member

Having these functions in executable callable form was set up a long time ago, and is possibly unnecessary

Should all these functions be combined into one files, (maybe elements.bsh ?)

This can be done in two steps to maintain compatibility. First move to the new file, and leave the current existing findin, etc... with a deprecation warning (on source), and then remove those at a later date.

Thoughts? @scott-vsi

@scott-vsi
Copy link
Contributor

I think ask_question should be included in this list as its executable signature is different from its functional one, which I think is actively harmful #275

@scott-vsi
Copy link
Contributor

scott-vsi commented Jan 12, 2021

I never use the executable version. The biggest problem to me with moving them to a new file is that a different file would have to be sourced. You could get around that by making findin source elements.bsh or something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants