Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker_compose_override: Handling windows paths on WCOW #169

Open
2 tasks
andyneff opened this issue Aug 22, 2019 · 0 comments
Open
2 tasks

docker_compose_override: Handling windows paths on WCOW #169

andyneff opened this issue Aug 22, 2019 · 0 comments

Comments

@andyneff
Copy link
Member

andyneff commented Aug 22, 2019

There are a number of issues when it comes to handling lcow, wcow, and lcol, in docker compose override. It needs to be overhauled to handle all three gracefully

  • Instead of Putting values of always putting variables in directly using bash in directions, for linux containers, this should be done, but for windows containers instead the variable names should be put in, this way bash path conversions will convert them to windows paths. This will work for both environment variables and volumes
  • Since a large part of the dynamic volume code will have to be rewritten for this, we should take the time to support mount instead of volumes: Proposed ideas
    • While arrays will still be supported, arrays will be internally converted to environment variables PROJECT_MOUNT_3, etc...
    • There will be a number of variables to check, PROJECT_MOUNT_SOURCE_1, PROJECT_MOUNT_DESTINATION_1, PROJECT_MOUNT_TYPE_1 (where type can be auto filled in based on if it starts with a / or not. Maybe even optional PROJECT_MOUNT_READONLY_1, etc...
    • Direct VOLUME support will be discontinued, it will always translate into volume.
    • The behavior of directories being created if they don't exist will not be replicated
    • optional idea: Volumes can even be added to the volumes: section.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant