Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove add_pipenv.py from new_notebook #146

Open
andyneff opened this issue May 28, 2019 · 1 comment
Open

Remove add_pipenv.py from new_notebook #146

andyneff opened this issue May 28, 2019 · 1 comment
Assignees
Labels

Comments

@andyneff
Copy link
Member

Having a jupyter server call pipenv on windows results in the inability to stop the kernel.

However using the virtualenv directly works without issue. pipenv run add_virtualenv.py

If there is no reason to keep add_pipenv.py, it should be removed completely

@andyneff andyneff added the bug label May 28, 2019
@andyneff andyneff self-assigned this May 28, 2019
@andyneff
Copy link
Member Author

A reference to the Pipfile directory should be added to the kernel.json if possible just to help a user remember where the pipfile dir is.

@andyneff andyneff changed the title Remove add_pipenv.pty from new_notebook Remove add_pipenv.py from new_notebook Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant