Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for some older versions of PHP and Laravel in the next major release #41

Open
adiachenko opened this issue Nov 18, 2021 · 7 comments
Assignees
Labels
enhancement New feature or request question Further information is requested

Comments

@adiachenko
Copy link
Collaborator

adiachenko commented Nov 18, 2021

At the moment our versions constraints are brittle and its getting harder to anticipate where things might break due to wide range of supported software.

I suggest to limit support to the following versions to ease maintenance burden:

  • PHP >= 7.4 (support for PHP 7.3 will end on December 6)
  • Laravel >= 6.0 (this is the last version that still receives security fixes)

This also allows us to clean up some other dependencies a bit:

  • "openzipkin/zipkin": "~2.0.2|~3.0" => "~3.0"
  • "phpunit/phpunit": "~7.0|~8.0" => "~9.0"

Users of older PHP/Laravel can still avail of older versions of the package.

Opinions? @Mulkave @KinaneD

@adiachenko adiachenko added enhancement New feature or request question Further information is requested labels Nov 18, 2021
@adiachenko adiachenko self-assigned this Nov 18, 2021
@jcchavezs
Copy link
Contributor

jcchavezs commented Nov 18, 2021 via email

@KinaneD
Copy link
Member

KinaneD commented Nov 18, 2021

+1

@KinaneD
Copy link
Member

KinaneD commented Nov 18, 2021

Though I just noticed that Zipkin 3.0 has not been released yet.

@jcchavezs
Copy link
Contributor

jcchavezs commented Nov 18, 2021 via email

@adiachenko
Copy link
Collaborator Author

Yeah, Zipkin 3 has been released and there is #40 on review to tag our own v2.1.0 (final) release that includes it.

@KinaneD
Copy link
Member

KinaneD commented Nov 19, 2021

It was indeed.
Thank you @adiachenko @jcchavezs 🦾

@Mulkave
Copy link
Member

Mulkave commented Nov 19, 2021

Good idea 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants