From 62d9e919792ab26ab88045daa07822e2dee9b9fa Mon Sep 17 00:00:00 2001 From: Kirpal Demian Date: Fri, 10 Feb 2023 14:40:45 -0500 Subject: [PATCH 1/3] chore: lock very_good_cli version in workflow --- .github/workflows/flutter_package.yml | 6 +++++- README.md | 7 +++++++ 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/.github/workflows/flutter_package.yml b/.github/workflows/flutter_package.yml index 8c8a59a..6510962 100644 --- a/.github/workflows/flutter_package.yml +++ b/.github/workflows/flutter_package.yml @@ -43,6 +43,10 @@ on: required: false type: boolean default: false + very_good_cli_version: + required: false + type: string + default: "0.11.0+1" working_directory: required: false type: string @@ -70,7 +74,7 @@ jobs: - name: 📦 Install Dependencies run: | - flutter pub global activate very_good_cli + flutter pub global activate very_good_cli ${{inputs.very_good_cli_version}}} very_good --analytics false very_good packages get --recursive diff --git a/README.md b/README.md index 3bfb90e..fce5c27 100644 --- a/README.md +++ b/README.md @@ -183,6 +183,12 @@ The Flutter package workflow consists of the following steps: **Default** `""` +#### `very_good_cli_version` + +**Optional** The version of [very_good_cli][very_good_cli_link] to use. + +**Default** `"0.11.0+1"` + #### `working_directory` **Optional** The path to the root of the Flutter package. @@ -381,6 +387,7 @@ jobs: [license_link]: https://opensource.org/licenses/MIT [logo_black]: https://raw.githubusercontent.com/VGVentures/very_good_brand/main/styles/README/vgv_logo_black.png#gh-light-mode-only [logo_white]: https://raw.githubusercontent.com/VGVentures/very_good_brand/main/styles/README/vgv_logo_white.png#gh-dark-mode-only +[very_good_cli_link]: https://pub.dev/packages/very_good_cli [very_good_ventures_link_dark]: https://verygood.ventures#gh-dark-mode-only [very_good_ventures_link_light]: https://verygood.ventures#gh-light-mode-only [very_good_ventures_link]: https://verygood.ventures From cbe8b4a470f15c02f45e2304b00e283d4c1e9e4d Mon Sep 17 00:00:00 2001 From: Felix Angelov Date: Tue, 21 Feb 2023 13:04:46 -0600 Subject: [PATCH 2/3] Apply suggestions from code review --- .github/workflows/flutter_package.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/flutter_package.yml b/.github/workflows/flutter_package.yml index 6510962..9777fc2 100644 --- a/.github/workflows/flutter_package.yml +++ b/.github/workflows/flutter_package.yml @@ -74,7 +74,7 @@ jobs: - name: 📦 Install Dependencies run: | - flutter pub global activate very_good_cli ${{inputs.very_good_cli_version}}} + flutter pub global activate very_good_cli ${{inputs.very_good_cli_version}} very_good --analytics false very_good packages get --recursive From 992fc9fea6799d7fcb5290bea13e73d8f9ccff38 Mon Sep 17 00:00:00 2001 From: Kirpal Demian Date: Wed, 22 Feb 2023 10:07:49 -0500 Subject: [PATCH 3/3] make default version empty --- .github/workflows/flutter_package.yml | 2 +- README.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/flutter_package.yml b/.github/workflows/flutter_package.yml index 6510962..f57583a 100644 --- a/.github/workflows/flutter_package.yml +++ b/.github/workflows/flutter_package.yml @@ -46,7 +46,7 @@ on: very_good_cli_version: required: false type: string - default: "0.11.0+1" + default: "" working_directory: required: false type: string diff --git a/README.md b/README.md index fce5c27..74b847c 100644 --- a/README.md +++ b/README.md @@ -187,7 +187,7 @@ The Flutter package workflow consists of the following steps: **Optional** The version of [very_good_cli][very_good_cli_link] to use. -**Default** `"0.11.0+1"` +**Default** `""` #### `working_directory`