-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: lock the version of the CLI in the workflows #90
Labels
feature
A new feature or request
good first issue
Good for newcomers
p2
Important issues not at the top of the work list
Comments
wolfenrain
added
bug
Something isn't working as expected
feature
A new feature or request
and removed
bug
Something isn't working as expected
labels
Nov 7, 2022
7 tasks
In review, PR #101 |
Rather than exposing an input to customize very_good_cli in the workflow shouldn't we treat breaking changes in very_good_cli as breaking changes in the workflow? I would rather not expose inputs in the workflow that tightly couple the workflow to very_good_cli since in the future we may decide to move away from very_good_cli (it's an internal implementation detail imo). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature
A new feature or request
good first issue
Good for newcomers
p2
Important issues not at the top of the work list
Description
We need to lock the CLI in the workflows in case we ever have a breaking change on it, currently it installs the latest and if people use older version of the workflows when there is a breaking change it will break that workflow accidentally.
The text was updated successfully, but these errors were encountered: