Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Swift Package Manager support #216

Open
2 tasks
rekire opened this issue Nov 23, 2024 · 4 comments
Open
2 tasks

feat: Swift Package Manager support #216

rekire opened this issue Nov 23, 2024 · 4 comments
Labels
feature A new feature or request p2 Important issues not at the top of the work list

Comments

@rekire
Copy link

rekire commented Nov 23, 2024

Description

The template generator should use the Swift Package Manager, the documentation mentions also the required parts to keep the "legacy" CocoaPods support.

Requirements

  • All CI/CD checks are passing.
  • There is no drop in the test coverage percentage.

Additional Context

No response

@tomarra
Copy link
Contributor

tomarra commented Nov 26, 2024

Hi @rekire 👋 Thanks for opening this issue.

We are aware of the move to Swift Package Manager and are excited for it to land. Given that right now it's only available in the main Flutter branch and not in a stable release we won't prioritize the work given that it's not a breaking change. When the SPM implementation lands the Cocoapods implementation will still be supported for sometime. When that happens we can re-evaluate this work and ensure that we can migrate safely and not effect the templates.

@tomarra tomarra added the p2 Important issues not at the top of the work list label Nov 26, 2024
@tomarra tomarra moved this from Needs Triage to Backlog in VGV Open Source 🦄 🧙🌟 Nov 26, 2024
@rekire
Copy link
Author

rekire commented Dec 12, 2024

@tomarra tomarra moved this from Backlog to Needs Triage in VGV Open Source 🦄 🧙🌟 Dec 17, 2024
@tomarra
Copy link
Contributor

tomarra commented Dec 17, 2024

Notes from Grooming Session with team

  • While support for this is released with 3.27 there is still an overarching message on the documentation saying "Swift Package Manager support is off by default. Flutter continues to support CocoaPods." Given this we shouldn't jump straight into this as the community packages still need to be updated as well.
  • We should take the time to look at this for very_good_flutter_plugin as this seems like the main one that would be effected. But again need to be cautious as to when we turn this support on.

@tomarra tomarra moved this from Needs Triage to Backlog in VGV Open Source 🦄 🧙🌟 Dec 17, 2024
@rekire
Copy link
Author

rekire commented Dec 17, 2024

The changes are not so big, to be honest. It is primarily a change of the folder structure, especially when you have no code yet. The CocoaPods usage of the same does not break. You just need to update the path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature or request p2 Important issues not at the top of the work list
Projects
Status: Backlog
Development

No branches or pull requests

2 participants