Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: very_good packages get -r silently quits if there is no flutter executable available #760

Open
incendial opened this issue Jul 10, 2023 · 0 comments
Labels
bug Something isn't working as expected p2 Important issues not at the top of the work list

Comments

@incendial
Copy link

Description
Hello!

When using very_good packages get -r on CI without Flutter being installed, the command silently quits without installing the dependencies. This behaviour is kinda misleading and a warning of some sort would be great to have.

For example,

jobs:
  check:
    runs-on: ubuntu-latest
    steps:
      - name: Checkout
        uses: actions/checkout@v3

      - name: Install Beta Dart
        uses: dart-lang/setup-dart@v1
        with:
          sdk: beta

      - name: Install Very Good CLI
        run: |
          dart pub global activate very_good_cli
          dart pub global run very_good_cli:very_good --analytics=false

      - name: Install dependencies
        run: dart pub global run very_good_cli:very_good packages get -r

The output looks like:
Screenshot 2023-07-10 at 14 36 48

Steps To Reproduce

  1. Create a github workflow with the steps above
  2. Run it
@incendial incendial added the bug Something isn't working as expected label Jul 10, 2023
@BeatriceMitchell BeatriceMitchell moved this from Needs Triage to Backlog in VGV Open Source 🦄 🧙🌟 Sep 14, 2023
@tomarra tomarra added the p2 Important issues not at the top of the work list label Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as expected p2 Important issues not at the top of the work list
Projects
Status: Backlog
Development

No branches or pull requests

2 participants