Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing documentation, wich kind of glob is used for: very_good test --exclude-coverage #654

Open
dkbast opened this issue Feb 15, 2023 · 2 comments
Labels
documentation Improvements or additions to documentation p3 Issues that we currently consider unimportant

Comments

@dkbast
Copy link

dkbast commented Feb 15, 2023

Description

very_good test --help

   --exclude-coverage                A glob which will be used to exclude files that match from the coverage.

Since "glob" can be any of many implementations/interpretations and the expected *.g.dart did not seem to work it would be great to know which kind of glob can be used.

Expected Behavior
The help should provide an example glob and/or specify which pattern matching is used e.g. --exclude-coverage '.g.dart'

@dkbast dkbast added the bug Something isn't working as expected label Feb 15, 2023
@dkbast
Copy link
Author

dkbast commented Feb 15, 2023

It also looks like its not being applied, the following command still generates coverage files for *.g.dart, maybe I'm doing something wrong?

very_good test --coverage --exclude-coverage '\.g\.dart' --no-optimization

@dkbast
Copy link
Author

dkbast commented Feb 28, 2023

Apparently the problem is that .g.dart only matches root level files and we need to write **/.g.dart to match files which are in folders - this can be closed, but maybe an example should be added for how to use this.

Using the exclude works, but introduces a whole new set of problems, because then all files with a part directive wont compile anymore.

@alestiago alestiago added documentation Improvements or additions to documentation and removed bug Something isn't working as expected labels Mar 28, 2023
@BeatriceMitchell BeatriceMitchell moved this from Needs Triage to Backlog in VGV Open Source 🦄 🧙🌟 Apr 4, 2023
@tomarra tomarra added the p3 Issues that we currently consider unimportant label Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation p3 Issues that we currently consider unimportant
Projects
Status: Backlog
Development

No branches or pull requests

3 participants