Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Dockerize the project #1162

Open
4 tasks
a-wallen opened this issue Oct 9, 2024 · 1 comment
Open
4 tasks

feat: Dockerize the project #1162

a-wallen opened this issue Oct 9, 2024 · 1 comment
Labels
bug Something isn't working as expected feature A new feature or request p2 Important issues not at the top of the work list

Comments

@a-wallen
Copy link

a-wallen commented Oct 9, 2024

Description

I'm developing on a windows machine, and tests for this project fail out of the box due to the difference in path separators on the host machine "" vs "/".

  1. One way to resolve this issue is to use something like 'Platform.pathSeparator'. Right now, it seems like "/" is hardcoded in some areas.

  2. Another way to resolve this is to dockerize the project

Requirements

  • All CI/CD checks are passing.
  • There is no drop in the test coverage percentage.

Additional Context

No response

@tomarra
Copy link
Contributor

tomarra commented Oct 21, 2024

HI @a-wallen, thanks for opening this issue up.

Overall I don't think that dockerizing the project is a direction we want to go. That being said I think the path separators point is something we can address and probably should to ensure compatibility across systems.

Do you have a list of specific tests that are failing for you that we could start to narrow the search for these hardcoded values on? Overall we don't do much if any development on Windows so we don't tend to run into these issues.

@tomarra tomarra added bug Something isn't working as expected p2 Important issues not at the top of the work list labels Oct 21, 2024
@tomarra tomarra moved this from Needs Triage to Backlog in VGV Open Source 🦄 🧙🌟 Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as expected feature A new feature or request p2 Important issues not at the top of the work list
Projects
Status: Backlog
Development

No branches or pull requests

2 participants