-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: local very_good create doesn't use imported templates #1161
Comments
This may be a duplicate of #1078 |
On the first glance my problem looks very much like #4295, which is mentioned inside #1078, that the local cli is not used, even if it was activated with the proper command and also successfully shown in the terminal. But as I mentioned in my additional context, when I activate the local cli and create a flutter_app, the very_good_core_templates.dart is used - which I would expect to actually include the very_good_core_bundle.dart. Therefore, it looks to me as if my local cli is being used on the one hand, but on the other hand, since the very_good_core_bundle.dart is not included/used, that the online version is being used there? Maybe I expect dart to work differently here than it does. I also tried as mentioned in #4295 to activate my local cli after I cleaned / deleted my pub-cache folder but with no success.
|
Hi @SareXx, thanks for opening this issue and the explanation. Overall I don't see this as an issue on the CLI package and more of a local setup issue overall. The update process for our bundles is working as expected. As was noted before, we do know of some issues with the pub cache when installing packages but this isn't something that we can fix inside of this package. Also we can't provide support for people forking our repo just given our staffing. If this is something you feel like you can work on and provide a PR for please let us know. Given this I'm going to close this out as a won't fix as I don't see a need for a change/update on the CLI package. |
Description
While working with the local very_good_cli and very_good_templates I ran into the issue that the very_good_cli doesn't use the modified very_good_core_bundle.dart and therefore
very_good create flutter_app
doesn't create a customized app.Steps To Reproduce
Prerequires
Steps to reproduce unexpected behavior
(very_good_templates/very_good_core/brick/{{project_name.snakeCase()}})
1.1 Adding an additional File
1.2 Adding additional dependencies in the pubspec.yaml
mason bundle . -t dart -o /path/to/export/
(very_good_cli/lib/src/commands/create/templates/very_good_core/)
very_good create flutter_app AppName
Expected Behavior
very_good create flutter_app AppName
creates a flutter app while using the very_good_core template, including the modified very_good_core_bundle.dartAdditional Context
I haven't changed any code in the cli, besides mentioned below, so I would assume that if the filename of the very_good_core_bundle.dart is correct, it should be used and my changes become created/implemented when I create a new app.
Am I missing an implementation step somewhere or is this what I'm trying to use your projects for even possible?
I can verify the following things:
To confirm that I'm using my local cli, I changed the comment block after when an app gets created in the very_good_core_template.dart in the cli project.
With a base64 decoder I can see from the pubspec.yaml string that my modifications are inside the bundle. Not to mention the new lines of my additional file.
The text was updated successfully, but these errors were encountered: