Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: packages get --ignore does work with "example" #1118

Open
alestiago opened this issue Aug 20, 2024 · 0 comments
Open

fix: packages get --ignore does work with "example" #1118

alestiago opened this issue Aug 20, 2024 · 0 comments
Labels
bug Something isn't working as expected p1 High-priority issues at the top of the work list

Comments

@alestiago
Copy link
Contributor

Description

Running:

very_good packages get -r --ignore example

Gets dependencies on the example directory.

Steps To Reproduce

  1. Activate Very Good CLI:
dart pub global activate very_good_cli
  1. Create a flutter package:
very_good create flutter_package my_package
  1. Create an example package inside my_package (from my_package):
flutter create example --platforms web
  1. Cleanmy_package/example (from my_package/example):
flutter clean && rm -rf pubspec.lock

Observe that build/, .dart_tool/ and pubspec.lock within examples are no longer existent.

  1. Get dependencies (from my_package)
very_good packages get -r --ignore example
  1. See that my_package/example has now build/, .dart_tool/ and pubspec.lock within the example directory meaning the tool run a pub get.

The logger only notifies:

✓ Running "flutter pub get" in .  (1.9s)

Expected Behavior
There is no pub get on the example directory when provided through ignore.

Additional Context
There is a hidden --no-example command that might be applicable.

@alestiago alestiago added the bug Something isn't working as expected label Aug 20, 2024
@tomarra tomarra moved this from Needs Triage to Todo in VGV Open Source 🦄 🧙🌟 Aug 27, 2024
@tomarra tomarra added the p1 High-priority issues at the top of the work list label Aug 27, 2024
@tomarra tomarra moved this from Todo to Backlog in VGV Open Source 🦄 🧙🌟 Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as expected p1 High-priority issues at the top of the work list
Projects
Status: Backlog
Development

No branches or pull requests

2 participants