Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: file-report disables optimization #1009

Open
DFelten opened this issue Apr 5, 2024 · 5 comments
Open

fix: file-report disables optimization #1009

DFelten opened this issue Apr 5, 2024 · 5 comments
Labels
bug Something isn't working as expected has reproductive steps This issue contains detailed steps to reproduce the issue p3 Issues that we currently consider unimportant

Comments

@DFelten
Copy link

DFelten commented Apr 5, 2024

Description

It is now possible to start the tests with an output as mentioned here. But when running a test with very_good and the file-reporter parameter, the parameter for optimization is no longer working.

Steps To Reproduce

Run test via

very_good test --optimization --coverage -- --file-reporter json:test_reports/dd_test_report.json

No test optimization appears in the terminal and the test needs four times as long. The .test_optimizer.dart file is not generated while the test is running.

Expected Behavior

The test should run with optimization and create a report.

Screenshots

CleanShot 2024-04-05 at 09 59 04@2x

@DFelten DFelten added the bug Something isn't working as expected label Apr 5, 2024
@alestiago alestiago added the has reproductive steps This issue contains detailed steps to reproduce the issue label May 16, 2024
@alestiago
Copy link
Contributor

Hi @DFelten ! Thank you for opening an issue sorry for the late reply, I've haven't been able to catch-up lately.

I've been able to reproduce this in the latest very_good_cli (0.21.0). @DFelten are you interested in contributing?

@robsonsilv4
Copy link

Hi @DFelten, any update or an idea/tip how to solve the problem?

@DFelten
Copy link
Author

DFelten commented Jul 11, 2024

Hi @DFelten, any update or an idea/tip how to solve the problem?

I haven't found a workaround, so the problem still exists. Unfortunately, I have no idea how I can solve the problem myself.

@Skisperd
Copy link

Skisperd commented Aug 9, 2024

Hi,

I'm experiencing the same issue described in this thread. When I run the command with --optimization and --file-reporter, the optimization is not applied, and the test execution time increases significantly. Additionally, the .test_optimizer.dart file is not generated during the test. I'm using very_good_cli 0.21.0.

I would like to know if there is any temporary workaround or if I can help in any way to contribute to the resolution of this issue.

Thank you in advance for your

@alestiago
Copy link
Contributor

alestiago commented Aug 13, 2024

Hi all, I'll try raising this within the team and see if it can get prioritised.


If any of you would like to contribute and have questions we're willing to help out and get your PR landed (let me know and I'll assign you to the issue).

In terms of resources, the CONTRIBUTING is a good place to start. Test optimisation relies internally on mason so knowledge with such tool might also help.

@tomarra tomarra added p3 Issues that we currently consider unimportant and removed waiting for response Waiting for follow up labels Oct 29, 2024
@tomarra tomarra moved this from Needs Triage to Backlog in VGV Open Source 🦄 🧙🌟 Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as expected has reproductive steps This issue contains detailed steps to reproduce the issue p3 Issues that we currently consider unimportant
Projects
Status: Backlog
Development

No branches or pull requests

5 participants