Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Http2 #1502

Open
2 tasks
markbreuss opened this issue Sep 5, 2024 · 2 comments
Open
2 tasks

Support for Http2 #1502

markbreuss opened this issue Sep 5, 2024 · 2 comments
Labels
feature A new feature or request p3 Issues that we currently consider unimportant

Comments

@markbreuss
Copy link

Description

I am currently facing an issue that google cloud run has a response size limit of 32Mib
Wich is not enough for our PDF reports.

The solution would be to switch over to http2:
image

As soon as I switch it, the bacckend does not work anymore.

My question is, does dartfrog support it?
If yes, do you have any ressources to point me to on how to set it up.
If no, are there any plans to support it?

Thanks for the help,

Mark

Requirements

  • All CI/CD checks are passing.
  • There is no drop in the test coverage percentage.

Additional Context

No response

@tomarra
Copy link
Contributor

tomarra commented Sep 24, 2024

Hi @markbreuss 👋 Thanks for opening this issue!

We did a bit of research on this and overall it seems like Dart/Shelf needs some more effort on this before we can pull it in to use for Dart Frog. While there is a Dart package for http2 it seems that the effort to pull this into shelf has had an open ticket since 2015, dart-lang/shelf#50

We will follow up with the Dart team on this to see if there is any progress from their side as a next step.

@tomarra tomarra moved this from Needs Triage to Backlog in VGV Open Source 🦄 🧙🌟 Sep 24, 2024
@tomarra tomarra added the p3 Issues that we currently consider unimportant label Sep 24, 2024
@tomarra
Copy link
Contributor

tomarra commented Oct 10, 2024

Given the update from the Dart team on dart-lang/shelf#50 it seems like this is something that they are not looking to add to shelf and would have to be a custom implementation. As we don't have a use case for this currently I'm going to leave it open as a P3 so if someone would like to work on it they could but it's not on our priority list at this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature or request p3 Issues that we currently consider unimportant
Projects
Status: Backlog
Development

No branches or pull requests

2 participants