Fix all errors/warnings found by CPPcheck #252
Description
1 accessMoved PR:#254
1 unsignedLessThanZero PR:#254
1 comparisonOfBoolWithBoolError PR:#254
1 funcArgOrderDifferent PR:#254
1 legacyUninitvar PR:#254
1 useInitializationList PR:#254
1 redundantContinue PR:#254
1 virtualCallInConstructor
2 containerOutOfBounds PR:#255
2 comparisonOfTwoFuncsReturningBoolError PR:#255
2 duplicateAssignExpression PR:#255
2 knownEmptyContainer PR:#255
2 truncLongCastAssignment PR:#255
2 noConstructor PR:#255
2 passedByValue PR:#255
2 duplicateCondition PR:#255
2 unknownMacro PR:#255
2 unusedVariable PR:#255
2 identicalConditionAfterEarlyExit PR:#255
3 invalidPrintfArgType_sint PR:#256
3 uninitvar #256
3 shiftTooManyBitsSigned PR:#256
5 nullPointerRedundantCheck PR:#257
6 invalidPrintfArgType_uint PR:#257
6 uninitMemberVar PR:#257
6 arithOperationsOnVoidPointer PR:#257
7 redundantInitialization PR:#256
2(10) derefInvalidIteratorRedundantCheck PR:#256
11 badBitmaskCheck PR:#256
12 syntaxError PR:#258
20 constParameterPointer PR:#258
32 missingOverride PR:#259
35 variableScope PR:#259
41 unreadVariable PR:#261
47 constParameterReference PR:#262
48 constVariableReference PR:#262
58 constVariable PR:#262
71 knownConditionTrueFalse PR:#263
66 shadowFunction PR:#265
TODO: 67 missingInclude
101 constVariablePointer #264
TODO: 177 unusedFunction
207 noExplicitConstructor PR: #274
271 useStlAlgorithm PR: #277 #283
784 cstyleCast PR: #281 #284 #285 #286 #287 #289 #291
https://buildbot-ci.vectorcamp.gr/#/builders/269/builds/2/steps/5/logs/stdio
false-positives:
-
uselessAssignmentArg PR:Fix marked as false positive uselessAssignmentArg cppcheck warning #267
-
redundantAssignment PR:Fix marked as false positive redundantAssignment cppcheck warnings #270
-
redundantPointerOp src/util/partitioned_set.h PR: Fix/Suppress remaining Cppcheck warnings #291
-
returnDanglingLifetime src/parser/Parser.rl:167:12 PR: Fix/Suppress remaining Cppcheck warnings #291
-
pointerLessThanZero src/parser/control_verbs.rl:111:16 PR: Fix/Suppress remaining Cppcheck warnings #291
-
pointerPositive src/parser/control_verbs.rl:111:16 PR: Fix/Suppress remaining Cppcheck warnings #291
-
constParameterCallback simplegrep.c:70:74 PR: Fix remaining marked as done const* cppcheck warnings #278
-
duplInheritedMember src/nfagraph/ng_holder.h:117:25 PR: Fix/Suppress remaining Cppcheck warnings #291
-
unsignedPositive src/util/partitioned_set.h:231:29 PR: Fix/Suppress remaining Cppcheck warnings #291
-
checkLevelNormal specify --check-level=exhaustive ADDED
-
4 duplicateExpression PR: Fix marked as done cppcheck warnings unreadVariable & others #279
-
4 constStatement PR: Fix marked as false positive constStatement cppcheck warnings #268
-
8 derefInvalidIteratorRedundantCheck NOT APPLICABLE ANYMORE
-
11 assertWithSideEffect PR: Fix/Suppress remaining Cppcheck warnings #291
false positives ignored in PR 255:
- containerOutOfBounds src/rose/rose_build_add_mask.cpp:192 PR: Fix/Suppress remaining Cppcheck warnings #291
- containerOutOfBounds benchmarks/benchmarks.cpp:243 PR: Fix/Suppress remaining Cppcheck warnings #291
- duplicateAssignExpression PR: Fix marked as false positive duplicateAssignExpression cppcheck warnings #269
- identicalConditionAfterEarlyExit PR:Fix marked as false positive identicalConditionAfterEarlyExit cppcheck warnings #271
- knownEmptyContainer src/nfa/goughcompile.cpp:924 PR: Fix/Suppress remaining Cppcheck warnings #291
- noConstructor unit/internal/repeat.cpp:67 PR: Fix/Suppress remaining Cppcheck warnings #291
- noConstructor unit/internal/repeat.cpp:730 PR: Fix/Suppress remaining Cppcheck warnings #291
- truncLongCastAssignment PR:Fix marked as false positive truncLongCastAssignment cppcheck warnings #272
- unknownMacro src/parser/ucp_table.h:818. PR: Fix marked as done cppcheck warnings unreadVariable & others #279
- unknownMacro unit/gtest/gtest-all.cc:1686 PR: Fix/Suppress remaining Cppcheck warnings #291
false positives from PR 257:
-
nullPointerRedundantCheck src/nfa/nfa_api_queue.h:254 PR: Fix marked as done cppcheck warnings unreadVariable & others #279
-
arithOperationsOnVoidPointer unit/internal/multi_bit.cpp:58: PR: Fix/Suppress remaining Cppcheck warnings #291
-
arithOperationsOnVoidPointer unit/internal/multi_bit_compress.cpp:97 PR: Fix/Suppress remaining Cppcheck warnings #291
-
uninitMemberVar PR: Fix/Suppress remaining Cppcheck warnings #291
false positives from PR 258:
-
syntaxError PR: Fix/Suppress remaining Cppcheck warnings #291
-
constParameterPointer src/nfa/limex_runtime_impl.h:930 PR: Fix remaining marked as done const* cppcheck warnings #278
-
constParameterPointer src/nfa/goughcompile.cpp:662 PR: Fix remaining marked as done const* cppcheck warnings #278
false positives ignored in PR 261:
Most are used in debug macros
unreadVariable src/stream_compress_impl.h:145:21. PR: #279
unreadVariable src/hwlm/hwlm.c:173:33 PR: #278
unreadVariable src/rose/match.c:271:38 PR: #279
unreadVariable src/fdr/fdr_confirm_compile.cpp:297:51 PR: #279
unreadVariable src/nfa/dfa_min.cpp:307:39 PR: #279
unreadVariable src/nfa/mcsheng_compile.cpp:1021:25 PR: #279
unreadVariable src/nfa/shengcompile.cpp:789:21 PR: #279
unreadVariable src/nfagraph/ng_repeat.cpp:858:44 PR: #279
unreadVariable src/nfagraph/ng_som.cpp:3136:16 PR: #279
unreadVariable src/parser/control_verbs.cpp:89:18 PR: #291
unreadVariable src/rose/rose_build_add.cpp:1042:33 PR: #279
unreadVariable src/rose/rose_build_long_lit.cpp:101:18 PR: #279
unreadVariable src/rose/rose_build_misc.cpp:864:19 PR: #279
unreadVariable unit/internal/state_compress.cpp:183:25 PR: #279
unreadVariable util/cross_compile.cpp:58:17. PR: #279
unreadVariable unit/internal/multi_bit_compress.cpp PR: #279
false positives from PR262:
constParameterReference src/nfa/goughcompile.cpp:444:72: PR: #278
constParameterReference src/nfa/mcsheng_compile.cpp:537: PR: #278
constVariableReference src/nfagraph/ng_limex_accel.cpp:466: PR: #291
constParameterReference src/rose/rose_build_anchored.cpp:870: PR: #278
false positives from PR263:
knownConditionTrueFalse PR: #291 (multiple)
src/hs_valid_platform.c:51:18: PR: #279
src/nfagraph/ng_puff.cpp PR:#273
src/nfagraph/ng_som.cpp PR:#273
src/nfagraph/ng_violet.cpp PR:#273
src/rose/rose_build_convert.cpp PR:#273
false positives from PR #264:
src/parser/prefilter.cpp:350:16 PR: #291
ignored in PR #274
src/util/flat_containers.h:65:5 PR: #291
src/util/insertion_ordered.h:67:5 PR: #291
src/parser/position_info.h:40:5 PR: #291
src/util/supervector/supervector.hpp:208:3 #276
src/util/supervector/supervector.hpp:211:3 #276
ignored in PR 277:
src/fdr/teddy_engine_description.cpp:74: useStlAlgorithm PR: #291