Hydroangeas is "too generous" with "infinite" water sources

[TheRealWormbo]

Mod Loader

Both Fabric and Forge (I confirm that I have tested both loaders and will specify both loader versions below)

Minecraft Version

1.20.1

Botania version

444

Modloader version

(any)

Modpack info

No response

The latest.log file

(n/a)

Issue description

The Hydroangeas only tests whether the consumed water source has two adjacent water sources, which is only part of the criteria that make a particular water source infinite. Consider the following setup:

Here the Hydroangeas drinks water from a waterlogged leaves block, which has two (out of reach) waterlogged leaves adjacent and air below. There are multiple reasons why that leaves block is not an infinite source:

• water cannot flow into that block from the adjacent blocks
• there is neither a water-obstructing block nor a water source below the block

Steps to reproduce

No response

Other information

This behavior can currently be used to generate mana without consuming water if the waterSourceConversion game rule is set to false. It also allows setups that are technically not based on infinite sources, such as two rows of Hydroangeas along a row of waterlogged leaves.

The question for adjusting this behavior also is: Should the flower detect infinite sources at all, or should it just let the game refill the removed water? And if it should detect sources, should that behavior also apply for infinite lava sources via game rule lavaSourceConversion?

[williewillus]

The flower's "infinte water detection" thing was originally added as a lag prevention measure. I don't know if it's relevant anymore since the engine's changed so much since 1.7. Could consider just reverting it to consuming water directly and letting the game refill to simplify things.