-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duplicate Mod Scripts Causing Errors #15
Labels
Comments
valkyrienyanko
changed the title
[Mod Loader] System.ArgumentException: An item with the same key has already been added. Key: res://Mod.cs
Mod Loader can't handle two mods with two scripts in the same location
Jun 27, 2024
valkyrienyanko
changed the title
Mod Loader can't handle two mods with two scripts in the same location
[Mod Loader] Can't handle two mods with two scripts in the same location
Aug 4, 2024
valkyrienyanko
added
bug
Something isn't working
poorly documented
and removed
help wanted
labels
Aug 6, 2024
valkyrienyanko
changed the title
[Mod Loader] Can't handle two mods with two scripts in the same location
[Mod Loader] Can't handle two mods with two scripts with the same script name
Aug 6, 2024
valkyrienyanko
changed the title
[Mod Loader] Can't handle two mods with two scripts with the same script name
[Mod Loader] Two mods each having a script with the same name causes errors
Aug 7, 2024
valkyrienyanko
changed the title
[Mod Loader] Two mods each having a script with the same name causes errors
Two mods each having a script with the same name causes errors
Aug 22, 2024
valkyrienyanko
changed the title
Two mods each having a script with the same name causes errors
Duplicate Mod Scripts Causing Errors
Sep 2, 2024
valkyrienyanko
changed the title
Duplicate Mod Scripts Causing Errors
[Mod Loader] Duplicate Mod Scripts Causing Errors
Sep 11, 2024
valkyrienyanko
changed the title
[Mod Loader] Duplicate Mod Scripts Causing Errors
Duplicate Mod Scripts Causing Errors
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
When creating duplicate mods with identical script names, errors occur during runtime. This issue affects both C# and GDScript mods.
Steps to Reproduce
res://Mods/Example Mod
directory tores://Mods/Example Mod 2
.id
in themod.json
of the new mod fromexample_mod
toexample_mod_2
.Expected Behavior
Both mods should load and execute without errors, printing unique greetings.
Actual Behavior
C# Mods
First Kind of Error:
Second Kind of Error:
GDScript Mods
Hello from Mod 1
andHello from Mod 2
Hello from Mod 1
printed twiceObservations
Proposed Solutions
Switch to GDScript for Mods:
Refactor C# Mod Loading:
Additional Notes
Conclusion
The current mod loading mechanism needs to be revised to handle duplicate script names across different mods effectively. Switching to GDScript or refactoring the C# mod loading process are potential solutions to address this issue.
The text was updated successfully, but these errors were encountered: