SSH key regular expression is too restrictive

[scop]

The regular expression used to validate SSH public key to use is too restrictive, it allows RSA keys only, and disallows ed25519 ones among others.

upcloud-whmcs-module/modules/servers/upCloudVps/lib/configOptions.php

Line 201 in bde802a

['fieldname' => 'ssh_key|SSH Public Key', 'fieldtype' => 'textarea', 'description' => $this->_LANG["sshRsa"], 'regexpr' => "#ssh-rsa AAAA[0-9A-Za-z+/]+[=]{0,3}( [^@]+@[^@]+)?#", "showorder" => "on"],

I wonder if this validation would be better off removed altogether, and have the UpCloud API do its validation on it? I'd say this would be the way to go if it yields good enough UX on errors.

[adityawbwce]

This will be replaced if we are addressing issue #44