Skip to content

Commit a381be2

Browse files
Merge pull request #23 from UofS-Pulse-Binfo/22-infraspecific_bug
infraspecific name bug
2 parents a617e7a + 47eb12c commit a381be2

File tree

2 files changed

+12
-4
lines changed

2 files changed

+12
-4
lines changed

includes/TripalImporter/GermplasmAccessionImporter.inc

+6-3
Original file line numberDiff line numberDiff line change
@@ -347,20 +347,23 @@
347347
'genus' => $genus,
348348
'species' => $one_accession['germplasm_species']
349349
);
350-
if ($one_accession['subtaxa']){
350+
if (!empty($one_accession['subtaxa'])){
351351
$match['infraspecific_name'] = $one_accession['subtaxa'];
352352
}
353+
else {
354+
$match['infraspecific_name'] = NULL;
355+
}
353356
$results = chado_select_record('organism', ['organism_id'], $match);
354357
if (count($results) > 1){
355-
$this->logMessage('ERROR: The genus, !genus, species, !species, has more than one matched organism in chado.organism.',['!genus' => $genus, '!species' => $one_accession['germplasm_species']], TRIPAL_WARNING);
358+
$this->logMessage('ERROR: The genus, !genus, species, !species, infraspecific, !infraspecific, has more than one matched organism in chado.organism.',['!genus' => $genus, '!species' => $one_accession['germplasm_species'], '!infraspecific' => $one_accession['subtaxa']], TRIPAL_WARNING);
356359
break;
357360
}
358361
elseif (count($results) == 1){
359362
//@log $this->logMessage('The stock, !stock, has one matched name in chado.stock.',['!stock' => $one_accession['name']], TRIPAL_WARNING);
360363
$organism_id = $results[0]->organism_id;
361364
}
362365
else{
363-
$this->logMessage('ERROR: The genus, !genus, species, !species, has no matched organism in chado.organism.',['!genus' => $genus, '!species' => $one_accession['germplasm_species']], TRIPAL_WARNING);
366+
$this->logMessage('ERROR: The genus, !genus, species, !species, infraspecific, !infraspecific, has no matched organism in chado.organism.',['!genus' => $genus, '!species' => $one_accession['germplasm_species'], '!infraspecific' => $one_accession['subtaxa']], TRIPAL_WARNING);
364367
break;
365368
}
366369

includes/TripalImporter/GermplasmCrossImporter.inc

+6-1
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,12 @@
7474
$organisms = array();
7575
$organisms[''] = '';
7676
while ($organism = $org_rset->fetchObject()) {
77-
$organisms[$organism->organism_id] = "$organism->genus $organism->species ($organism->common_name)";
77+
if ($organism->infraspecific_name){
78+
$organisms[$organism->organism_id] = "$organism->genus $organism->species $organism->infraspecific_name ($organism->common_name)";
79+
}
80+
else{
81+
$organisms[$organism->organism_id] = "$organism->genus $organism->species ($organism->common_name)";
82+
}
7883
}
7984

8085
$form['instructions'] = [

0 commit comments

Comments
 (0)