feat: Send progress events from Host to Guest #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binarybaron
force-pushed
the
tauri-events
branch
2 times, most recently
from
b1d4e93 to
8d6cd69
Compare
|
This PR is getting quite large (+ big scope) while implementing important core functionality. We need to make sure the code here is rock solid. We should try to merge this as soon as possible with a minimal feature set. Large PRs are hard to review. It's better to add more functionality later with new PRs. |
Closed
binarybaron
force-pushed
the
tauri-events
branch
2 times, most recently
from
f86833f to
9f46df0
Compare
binarybaron
changed the title
binarybaron
commented
Aug 25, 2024
| @@ -29,6 +30,14 @@ export default function InitPage() { | |||
| (state) => state.providers.selectedProvider, | |||
| ); | |||
|
|
|||
| async function init() { | |||
| await buyXmr( | |||
| providerToConcatenatedMultiAddr(selectedProvider), | |||
There was a problem hiding this comment.
This should be called in buy_xmr instead.
src-gui/src/renderer/components/pages/history/table/HistoryRowActions.tsx
Outdated
Show resolved
Hide resolved
|
I think the last 9 commits or so are mostly a back and forth and can be squashed |
binarybaron
force-pushed
the
tauri-events
branch
from
7c31c63 to
5dc8eb7
Compare
…ce Tauri events - Implement trait-based request handling in api/request.rs - Add Tauri bindings and event system in api/tauri_bindings.rs - Refactor CLI command parsing and execution in cli/command.rs - Update RPC methods to use new request handling approach - Emit Tauri events in swap/src/protocol/bob/swap.rs - Add typescript type bindings use typeshare crate
Einliterflasche
force-pushed
the
tauri-events
branch
from
2b25782 to
88c7f11
Compare
- Replace Electron IPC with Tauri invoke() for API calls - Implement TauriSwapProgressEvent for state management - Remove IpcInvokeButton, replace with PromiseInvokeButton - Update models: new tauriModel.ts, refactor rpcModel.ts - Simplify SwapSlice state, remove processRunning flag - Refactor SwapStatePage to use TauriSwapProgressEvent - Update HistoryRow and HistoryRowActions for new data structures - Remove unused Electron-specific components (e.g., RpcStatusAlert) - Update dependencies: React 18, Material-UI v4 to v5 - Implement typeshare for Rust/TypeScript type synchronization - Add BobStateName enum for more precise swap state tracking - Refactor utility functions for Tauri compatibility - Remove JSONStream and other Electron-specific dependencies
binarybaron
force-pushed
the
tauri-events
branch
from
d7e24df to
349035d
Compare
Einliterflasche
approved these changes
Aug 26, 2024
| @@ -49,45 +33,52 @@ export default function SwapStatePage({ | |||
| if (swapState === null) { | |||
| return <InitPage />; | |||
| } | |||
| if (isSwapStateInitiated(swapState)) { | |||
| if (swapState.type === "Initiated") { | |||
There was a problem hiding this comment.
This part might benefit from using switch case
binarybaron
added a commit
that referenced
this pull request
Aug 28, 2024
- Use the Request trait introduced in #10 for the RPC server - Delegate deserialization of RPC server method parameters to serde by using structs like BuyXmrArgs - Remove `get_raw_states` RPC server method because it's not used - Fix RPC server tests including removing test for the "log reference id" feature which was removed as part of #10 - Rename GetCurrentSwap struct to GetCurrentSwapArgs
binarybaron
added a commit
that referenced
this pull request
Aug 28, 2024
- Use the Request trait introduced in #10 for the RPC server - Delegate deserialization of RPC server method parameters to serde by using structs like BuyXmrArgs - Remove `get_raw_states` RPC server method because it's not used - Fix RPC server tests including removing test for the "log reference id" feature which was removed as part of #10 - Rename GetCurrentSwap struct to GetCurrentSwapArgs
binarybaron
added a commit
that referenced
this pull request
Aug 28, 2024
- Use the Request trait introduced in #10 for the RPC server - Delegate deserialization of RPC server method parameters to serde by using structs like BuyXmrArgs - Remove `get_raw_states` RPC server method because it's not used - Fix RPC server tests including removing test for the "log reference id" feature which was removed as part of #10 - Rename GetCurrentSwap struct to GetCurrentSwapArgs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before merging this we need to: