Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add at least one more price source to ASB #227

Open
darkness-su opened this issue Dec 7, 2024 · 0 comments
Open

Add at least one more price source to ASB #227

darkness-su opened this issue Dec 7, 2024 · 0 comments

Comments

@darkness-su
Copy link

Currently only Kraken's price API is compatible with ASB. This creates an attack surface as price manipulation at quote time on the corresponding Kraken pair could be used to exploit makers for a large amount.

See the following article where such manipulation was used on Coinbase to exploit major DeFi protocol Compound:
https://rekt.news/coinbase-the-oracle/

This would likely be unprofitable for now due to the amount of available liquidity, but would likely become a problem later.

It would be best to aggregate multiple sources and calculate an average to prevent such events.

Other websocket sources:

  • Binance Futures
  • Bybit Futures
  • Kucoin (spot and/or futures)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant