feat(asb): Print more information when history command is invoked #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This closes #211? |
|
|
||
| let all_swaps = db.all().await?; | ||
| for (swap_id, state) in all_swaps { | ||
| match SwapDetails::from_db_state(swap_id.clone(), state, &db).await { |
There was a problem hiding this comment.
We're calling from_db_state for every swap, but from_db_state iterates through all swaps itself. That's O(n^2), so we should probably move that into a single database query
There was a problem hiding this comment.
from_db_state does not iterate through all swaps. It iterates through all saved states of a particular swap.
|
Would also be cool to make this generic over AliceState / BobState and move it onto common/ |
binarybaron
force-pushed
the
asb/enhance-history-cmd
branch
from
a350812 to
49c6d8c
Compare
binarybaron
changed the title
binarybaron
force-pushed
the
asb/enhance-history-cmd
branch
from
85f6810 to
c5f2961
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #211