Switch to upstream version of express-openapi #5070
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
thomasheartman
force-pushed
the
chore/upstream-express-openapi
branch
from
e1a5a04 to
a8df26a
Compare
thomasheartman
commented
Oct 18, 2023
| @@ -292,11 +292,12 @@ export async function setupAppWithCustomAuth( | |||
|
|
|||
| export async function setupAppWithBaseUrl( | |||
| stores: IUnleashStores, | |||
| baseUriPath = '/hosted', | |||
There was a problem hiding this comment.
This is for convenience. Being able to choose the base path makes sense in the openapi tests, so this seems like a good choice to me.
This is ignored for now, but will be made available in the next version of the package.
Note: this will break some of the new tests we've added. This is intended.
thomasheartman
force-pushed
the
chore/upstream-express-openapi
branch
from
328c12e to
cacca6b
Compare
|
Closed in favor of #5259 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a work in progress. It's waiting for the required changes to express-openapi to be upstreamed. Before then, this cannot be merged.