fix: include tags in variants event

[nunogois]

https://linear.app/unleash/issue/2-1396/fix-variants-event-should-include-the-respective-feature-flag-tags

This fixes an issue where the feature-environment-variants-updated event would not post to a tagged Slack channel, since it would not take into consideration the feature flag tags.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments

Name	Status	Preview	Updated (UTC)
unleash-docs	⬜️ Ignored (Inspect)		Sep 14, 2023 10:06am
unleash-monorepo-frontend	⬜️ Ignored (Inspect)		Sep 14, 2023 10:06am

[gastonfournier]

I think this solves the problem, but... where should we add this query for tags?

We're adding a side effect on the creation of the event to add something that's unrelated with the event itself. Should we do this query instead in the SlackApp addon when we receive an event with a featureName and tags === undefined?

[chriswk]

Nice catch.

[nunogois]

I think this solves the problem, but... where should we add this query for tags?

We're adding a side effect on the creation of the event to add something that's unrelated with the event itself. Should we do this query instead in the SlackApp addon when we receive an event with a featureName and tags === undefined?

Good point, however this seems like our approach for other events as well, so at least it's consistent. There are many examples of this exact flow in feature-toggle-service. Perhaps we should evaluate whether there's a better way of fetching the feature tags, but I think it falls outside of the scope for this fix.

[gastonfournier]

Good point, however this seems like our approach for other events as well, so at least it's consistent. There are many examples of this exact flow in feature-toggle-service. Perhaps we should evaluate whether there's a better way of fetching the feature tags, but I think it falls outside of the scope for this fix.

Ok, standardization is a good reasoning to continue with this idea, I'm just thinking that by following my proposal, we can remove all this duplicated code, and we may even catch other events that are in the same situation. After all, not all listeners of the event need to know about the tags, we're adding this information just because of the way we built Slack Addon, therefore we're coupling our code to one particular solution.

But I agree, we can consider it out of the scope, especially if this involves changing other unrelated parts of the codebase.