fix: remove last seen by env #4659
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sets package.json version to 5.4
https://linear.app/unleash/issue/2-1128/change-the-api-to-support-adding-multiple-roles-to-a-usergroup-on-a https://linear.app/unleash/issue/2-1125/be-able-to-fetch-all-roles-for-a-user-in-a-project https://linear.app/unleash/issue/2-1127/adapt-the-ui-to-be-able-to-do-a-multi-select-on-role-permissions-for - Allows assigning project roles to groups with root roles - Implements new methods that support assigning, editing, removing and retrieving multiple project roles in project access, along with other auxiliary methods - Adds new events for updating and removing assigned roles - Adapts `useProjectApi` to new methods that use new endpoints that support multiple roles - Adds the `multipleRoles` feature flag that controls the possibility of selecting multiple roles on the UI - Adapts `ProjectAccessAssign` to support multiple role, using the new methods - Adds a new `MultipleRoleSelect` component that allows you to select multiple roles based on the `RoleSelect` component - Adapts the `RoleCell` component to support either a single role or multiple roles - Updates the `access.spec.ts` Cypress e2e test to reflect our new logic - Updates `access-service.e2e.test.ts` with tests covering the multiple roles logic and covering some corner cases - Updates `project-service.e2e.test.ts` to adapt to the new logic, adding a test that covers adding access with `[roles], [groups], [users]` - Misc refactors and boy scouting  --------- Co-authored-by: David Leek <[email protected]> Co-authored-by: Mateusz Kwasniewski <[email protected]> Co-authored-by: Nuno Góis <[email protected]>
This PR fixes a bug reported from a customer where deleting a legal value that was used in a strategy constraint would make it impossible to edit the constraint. [The bug was introduced here](#4473) The core of the problem introduced was that the values used to calculate illegal values was based on changing state. On the first render it would display correct state as it would match the legal values coming from the context definition with the legal values currently used in the constraint as values. However, when you triggered the onClick method for the checkboxes the state would be changed because we would remove the illegal values from the valueset and only insert current legal values in the state. This would trigger a re-render of the component, and now the data used to identify the illegal values would no longer be correct, because the bad values had been cleaned from the state. This would cause the UI for constraints to display incorrectly. Changed the flow to now give you a warning if you have illegal values, and that if you make changes and save the strategy these values will be removed from the constraint: <img width="726" alt="Skjermbilde 2023-08-25 kl 08 56 02" src="https://github.com/Unleash/unleash/assets/16081982/78e9875d-d864-4e21-bfb7-a530247a07eb"> Also amended this to apply to the single legal value constraints. <img width="721" alt="Skjermbilde 2023-08-25 kl 08 57 40" src="https://github.com/Unleash/unleash/assets/16081982/237a11d0-5c05-445c-9e99-b79cab0bff94">
Adds a setting to OIDC SSO configuration that controls whether or not additional scopes are to be requested during login <img width="944" alt="Skjermbilde 2023-08-24 kl 09 00 54" src="https://github.com/Unleash/unleash/assets/707867/8cf06fb4-aefd-48cd-b09b-99d35a2a10ed"> --------- Co-authored-by: Nuno Góis <[email protected]>
…n endpoint (#4579) ## About the changes Returns either 400 or 404 when token isn't found or doesn't match single project must be provided projectId criteria <!-- Does it close an issue? Multiple? --> Closes # Linear 2-1003 ## Discussion points <!-- Anything about the PR you'd like to discuss before it gets merged? Got any questions or doubts? --> Is projects.length > 1 a 400?
## About the changes Returns Not Found on create and get project api tokens when given a project id that doesn't exist ## Discussion points - This is an extra lookup per execution of the endpoint
* Adds initial support for estimating dora metric lead time for changes per feature toggle
Hackathon --------- Co-authored-by: chriswk <[email protected]>
This change sorts the tags in the tags file and tests that the list is sorted alphabetically. This makes it easier to find tags in the file. #4580 already introduced a test to check that we have no duplicate tags, so this isn't as necessary anymore, but it's still nice to have. It also removes the previous auto-sorting before exporting. This is to ensure that entries are sorted in the source list. This might seem like a regression, but it makes it easier to spot near-duplicate tags: > Despite having the test that validates there are no duplicates, you can always have Notifications and Notification API by mistake (tags that mean the same but are different). Keeping the list alphabetically sorted might help to prevent this before pushing the change to prod. In this case, we will eventually find out and fix it, so this could be a good reason to have the list sorted.
## About the changes Adds troubleshooting guides for some common problems under the how-to area (following the [diataxis framework](https://diataxis.fr/)). This is part of Unleash 2023 offsite challenge --------- Co-authored-by: Drew Gorton <[email protected]> Co-authored-by: Diego Susa <[email protected]> Co-authored-by: Michael Vittiglio <[email protected]> Co-authored-by: Thomas Heartman <[email protected]>
Should help cleaning up some of these: 
## About the changes Add additional event that can be configured inside Slack App Addon
<!-- Thanks for creating a PR! To make it easier for reviewers and everyone else to understand what your changes relate to, please add some relevant content to the headings below. Feel free to ignore or delete sections that you don't think are relevant. Thank you! ❤️ --> ## About the changes https://linear.app/unleash/issue/1-1268/add-remove-option-inside-configure-integration-page 
## About the changes Cleanup after hackathon. Discovered project on: https://linear.app/unleash/project/active-users-and-instance-dashboard-67352abadf49
## About the changes Redesigned/refactored integrations form.  Closes [1-1298/resesign-of-integrations-form](https://linear.app/unleash/issue/1-1298/resesign-of-integrations-form)
Reverts #4633 because of #4633 (comment)
Fix addon schema breaking build
#4635) ## About the changes Returns a 404 response instead of 500 when trying to set an environment on a project that doesn't exist
https://linear.app/unleash/issue/2-1373/small-ui-fixes-and-improvements - Update group root role `HelpIcon` tooltip to reflect the new behavior; - Fixes a crash on groups search where `description` could be `undefined`; - Improves `RoleDescription` design; - Fixes the role label in `ProjectGroupView`; 
This PR includes: * Tests for retrieving lead time per feature toggle and project average * Feedback component
## About the changes
Instead of this:
```ts
const { uiConfig } = useUiConfig();
const myFlag = Boolean(uiConfig?.flags?.myFlag)
```
we can have this:
```ts
const myFlag = useUiFlag("myFlag")
```
With the same type safety, less verbose and more purposeful code.
### Important files
- `frontend/src/hooks/useUiFlag.ts`
## Discussion points
Can we in the future share flags between frontend and backend? Right now
adding a new flag has to be done in 4 different places (backend flag
keys list, backend flags defaults config, backend experimental server
options, frontend type).
Most ergonomic option is to pull config directly from Unleash.
Issue, based on previous user feedback:
#4565
Internal feature request document:
[docs.google.com/document/d/1Sx0q...](https://docs.google.com/document/d/1Sx0qKZXUVUCjuY5F4MOh1ieOM1A2_jE58zEA7jaM_1g/edit?usp=sharing)
## About the changes Fix submitting integrations form
This PR adds a reference doc and a how-to doc for feature flag naming patterns. Extra thanks to @sebastian-bury for the draft from the offsite 👏🏼
https://linear.app/unleash/issue/2-1130/documentation-about-multiple-project-roles - Adds a section for the feature in the "Role-based Access control" reference doc; - Removes the mention that "Groups that *do* have a root role can't be assigned to a project." which is no longer true; - Adds a reference to multiple project roles in the "How to create and assign custom project roles" guide; - Fixes a wrong sentence in the "Assigning custom project roles" section of the aforementioned guide; --------- Co-authored-by: Thomas Heartman <[email protected]>
Adds `number` as possible payload type for variant. Adds a flag to enable the feature Updates all relevant models and schemas Adds the option to the UI Closes: # [1-1357](https://linear.app/unleash/issue/1-1357/support-number-in-variant-payload) --------- Signed-off-by: andreas-unleash <[email protected]>
Signed-off-by: andreas-unleash <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
gardleopard
suggested changes
Sep 12, 2023
andreas-unleash
requested review from
thomasheartman and
dgorton
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Closes #
Important files
Discussion points