Fix/dora polish #4645
Fix/dora polish #4645
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
FredrikOseberg
force-pushed
the
fix/dora-polish
branch
from
342623b to
7b30242
Compare
| <Typography>Is this useful to you?</Typography> | ||
| <StyledBtnContainer> | ||
| <Button | ||
| sx={{ marginRight: '0.5rem' }} |
There was a problem hiding this comment.
We moved away from using rems, but use theme.spacing instead.
There was a problem hiding this comment.
Nice catch, I thought I removed all of those. Will fix.
| `project:metrics:plausible`, | ||
| { sent: false } | ||
| ); | ||
| const [sentObj, setSentObj] = useState(value); |
There was a problem hiding this comment.
Can this have more meaningful name?
There was a problem hiding this comment.
It could be sent, but then it would be sent.sent which is not ideal. I will think on it.
There was a problem hiding this comment.
What are we sending, metrics? Maybe it can be called something like that. Sent is already in payload.
There was a problem hiding this comment.
Much better. Thank you.
| } | ||
| }; | ||
|
|
||
| const recipientEmail = '[email protected]'; |
| } | ||
| }; | ||
|
|
||
| const recipientEmail = '[email protected]'; |
There was a problem hiding this comment.
Placeholder until we can create a UX team email address
| <StyledIconWrapper> | ||
| <Send /> | ||
| </StyledIconWrapper> | ||
| <StyledLink href={mailtoURL}> |
There was a problem hiding this comment.
This link does not work for me, but maybe its because I need to set default mail client. Not sure.
| </StyledHeader> | ||
| <Typography> | ||
| We are considering adding project metrics to see how a project | ||
| performs. As a first step, we have added a lead time for changes |
There was a problem hiding this comment.
lead time for changes could be different style, so it is easier to read and understand, that this is the name. Bold or italics or background.
| @@ -0,0 +1,160 @@ | |||
| import { useState, useEffect } from 'react'; | |||
| import { Box, Button, Divider, Typography, styled } from '@mui/material'; | |||
| import { ChatBubble, PermMedia, Send } from '@mui/icons-material'; | |||
| sx={{ display: 'flex', justifyContent: 'center' }} | ||
| data-loading | ||
| > | ||
| {dora.projectAverage - original.timeToProduction} days |
There was a problem hiding this comment.
dora seems to be missing any types. It should come from hook.
There was a problem hiding this comment.
Backend needs to be merged before I can generate from enterprise
| @@ -8,6 +8,11 @@ export const projectDoraMetricsSchema = { | |||
| required: ['features'], | |||
| description: 'A projects dora metrics', | |||
| properties: { | |||
| projectAverage: { | |||
| type: 'number', | |||
| description: | |||
There was a problem hiding this comment.
What are the units? Maybe we can include that in description. minutes, hours, days?
There was a problem hiding this comment.
Good suggestion
Addressed what I could. Added some follow up items that I will tackle later. |
This PR includes: