feat: allow access to sdk state #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivarconr
reviewed
Jun 24, 2024
| return this.readyEventEmitted; | ||
| } | ||
|
|
||
| public getError(): SdkState { |
There was a problem hiding this comment.
can we rename to "getLastError"?
There was a problem hiding this comment.
It has the logic to return undefined it when current SDK state is not an error. getLastError in my mind indicates that it returns last error even if SDK already recovered - that's not the case here
There was a problem hiding this comment.
ok, thanks for clarifying. makes sense.
ivarconr
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Push model for state changes is not enough when passing client to React SDK,
see Unleash/proxy-client-react#168