Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add app & environment variant override support #178

Closed
mrizk opened this issue Aug 27, 2024 · 3 comments · Fixed by #179
Closed

Add app & environment variant override support #178

mrizk opened this issue Aug 27, 2024 · 3 comments · Fixed by #179
Assignees

Comments

@mrizk
Copy link
Contributor

mrizk commented Aug 27, 2024

Describe the feature request

At the moment, the SDK doesn't support setting a variant override for appName / environment despite this being supported by Unleash. Only userId, sessionId, and remoteAddress are supported.

func (o Override) getIdentifier(ctx *context.Context) string {

Screenshot 2024-08-27 at 14 35 12

This is a trivial feature to support, I could open a PR but wasn't sure what the contribution guidelines are on this project.

Background

No response

Solution suggestions

Add cases for appName & environment to Override.getIdentifier() and return their values from the context.

@ivarconr
Copy link
Member

This is a trivial feature to support, I could open a PR but wasn't sure what the contribution guidelines are on this project.

Great, please feel free to open a PR.

@mrizk
Copy link
Contributor Author

mrizk commented Aug 28, 2024

@ivarconr done

@github-project-automation github-project-automation bot moved this from Support rotation to Done in Issues and PRs Aug 29, 2024
@sighphyre
Copy link
Member

Thanks for patching this @mrizk, it's definitely a missing feature in the SDK but from a perspective of the wider Unleash ecosystem, not having that is a bug so I've done a patch release for this

Appreciate the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants