Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unleash edge chart doesn't support configuring the behaviour #175

Closed
JorTurFer opened this issue Oct 25, 2024 · 2 comments
Closed

Unleash edge chart doesn't support configuring the behaviour #175

JorTurFer opened this issue Oct 25, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@JorTurFer
Copy link

JorTurFer commented Oct 25, 2024

Describe the bug

Recent changes applied on the edge are showing errors during the edge startup informing that future releases won't start if I don't set the behaviour. Currently there isn't any way to configure this and neither a default behaviour set:

- name: {{ include "unleash-edge.name" . }}
args: ["edge"]
env:
- name: UPSTREAM_URL
value: "{{ .Values.edge.upstreamUrl }}"
{{- if .Values.edge.logLevel }}
- name: RUST_LOG
value: "{{ .Values.edge.logLevel }}"
{{- end }}
{{- if .Values.existingSecrets }}
{{- toYaml .Values.existingSecrets | nindent 12 }}
{{- end }}
{{- if .Values.edge.logFormat }}
- name: LOG_FORMAT
value: "{{ .Values.edge.logFormat }}"
{{- end }}
{{- if .Values.env }}
{{- toYaml .Values.env | nindent 12 }}
{{- end }}

The error:

2024-10-25T11:24:54.911113Z ERROR unleash_edge::builder: You should explicitly opt into either strict or dynamic behavior. Edge has defaulted to dynamic to preserve legacy behavior, however we recommend using strict from now on. Not explicitly opting into a behavior will return an error on startup in a future release

Steps to reproduce the bug

Use the latest helm chart

@JorTurFer JorTurFer added the bug Something isn't working label Oct 25, 2024
@chriswk
Copy link
Member

chriswk commented Oct 29, 2024

All behaviour is configurable through environment variables. So you can configure it just using normal env declarations
E.g.

env:
   - name: STRICT
     value: true

Feel free to make a PR if you need it in the next few days. If not, I'll see if I can't add an explicit setting.

@chriswk chriswk self-assigned this Oct 29, 2024
@JorTurFer
Copy link
Author

No no, no worries at all! I didn't know that STRICT works to enable the behaviour because I missed that part 🤦
image

Sorry and thanks again for the support! 🙇

@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

2 participants