Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ASM to support newer java versions #278

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Conversation

Saloed
Copy link
Collaborator

@Saloed Saloed commented Nov 18, 2024

No description provided.

Copy link
Contributor

Lifecycle test results

78 tests  ±0   78 ✅ ±0   1m 41s ⏱️ -2s
 7 suites ±0    0 💤 ±0 
 7 files   ±0    0 ❌ ±0 

Results for commit 9f6670c. ± Comparison against base commit 9733174.

Copy link
Contributor

Test results on JDK 19

   88 files  ±0     88 suites  ±0   14m 8s ⏱️ +31s
2 529 tests ±0  2 488 ✅ ±0  41 💤 ±0  0 ❌ ±0 
2 557 runs  ±0  2 516 ✅ ±0  41 💤 ±0  0 ❌ ±0 

Results for commit 9f6670c. ± Comparison against base commit 9733174.

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.51%. Comparing base (9733174) to head (9f6670c).
Report is 1 commits behind head on neo.

Additional details and impacted files
@@            Coverage Diff            @@
##                neo     #278   +/-   ##
=========================================
  Coverage     59.51%   59.51%           
  Complexity     2615     2615           
=========================================
  Files           320      320           
  Lines         19376    19376           
  Branches       2880     2880           
=========================================
  Hits          11531    11531           
  Misses         6761     6761           
  Partials       1084     1084           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Test results on JDK 11

   88 files  ±0     88 suites  ±0   14m 36s ⏱️ -32s
2 529 tests ±0  2 490 ✅ ±0  39 💤 ±0  0 ❌ ±0 
2 557 runs  ±0  2 518 ✅ ±0  39 💤 ±0  0 ❌ ±0 

Results for commit 9f6670c. ± Comparison against base commit 9733174.

Copy link
Contributor

Test results on JDK 8

   88 files  ±0     88 suites  ±0   18m 53s ⏱️ +57s
2 529 tests ±0  2 485 ✅ ±0  44 💤 ±0  0 ❌ ±0 
2 557 runs  ±0  2 513 ✅ ±0  44 💤 ±0  0 ❌ ±0 

Results for commit 9f6670c. ± Comparison against base commit 9733174.

@Saloed Saloed merged commit 81ccf5a into neo Nov 18, 2024
11 checks passed
@Saloed Saloed deleted the saloed/upgrade-asm branch November 18, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant