Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppress initial interface down alarms with config option #367

Closed
wants to merge 2 commits into from
Closed

Suppress initial interface down alarms with config option #367

wants to merge 2 commits into from

Conversation

johannaengland
Copy link
Contributor

@johannaengland johannaengland commented Sep 2, 2024 •
edited
Loading

Scope and purpose

Closes #257.

This is how I interpreted this issue: We have a config option that if it is set to true the first time a PortStateEvent would be created with the interface down state nothing happens instead.

Contributor Checklist

Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to Zino can be found in the
README.

  • Added a changelog fragment for towncrier
  • Added/amended tests for new/changed code
  • Added/changed documentation
  • Linted/formatted the code with black, ruff and isort, easiest by using pre-commit
  • The first line of the commit message continues the sentence "If applied, this commit will ...", starts with a capital letter, does not end with punctuation and is 50 characters or less long. See https://cbea.ms/git-commit/
  • If applicable: Created new issues if this PR does not fix the issue completely/there is further work to be done

@johannaengland johannaengland added the enhancement New feature or request label Sep 2, 2024
@johannaengland johannaengland self-assigned this Sep 2, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov Codecov
Copy link

codecov bot commented Sep 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.66%. Comparing base (e2164d5) to head (1409037).
Report is 9 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #367   +/-   ##
=======================================
  Coverage   98.66%   98.66%           
=======================================
  Files          77       77           
  Lines        9706     9711    +5     
=======================================
+ Hits         9576     9581    +5     
  Misses        130      130

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johannaengland johannaengland marked this pull request as draft September 2, 2024 10:36
@johannaengland johannaengland added the blocked This issue needs something else to be done before it can be resolved label Sep 2, 2024
@johannaengland
Copy link
Contributor Author

Settings this to draft/blocked until we get more concrete specification on how this should work

@johannaengland johannaengland deleted the feature/suppress-initial-down-alarms branch September 16, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunkwill42 lunkwill42 Awaiting requested review from lunkwill42

@stveit stveit Awaiting requested review from stveit

Assignees

@johannaengland johannaengland

Labels
blocked This issue needs something else to be done before it can be resolved enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Suppress alarms/tickets on initial import of a device / interface
1 participant
@johannaengland