Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a new management profile type for REST APIs #2894

Open
lunkwill42 opened this issue May 2, 2024 · 2 comments
Open

Make a new management profile type for REST APIs #2894

lunkwill42 opened this issue May 2, 2024 · 2 comments
Assignees
Labels
discussion Requires developer feedback/discussion before implementation enhancement PaloAlto seeddb

Comments

@lunkwill42
Copy link
Member

Is your feature request related to a problem? Please describe.

#2613 added a new Palo Alto ARP plugin that fetches data from the built-in REST API on Palo Alto firewalls. This plugin gets API credentials from ipdevpoll.conf, which is not desirable in the long run. This kind of information should rather be stored in its own kind of management profile, so it can be added through the Seed Database tool and be re-used across multiple devices.

Describe the solution you'd like

It is not clear to me at this point whether "Palo Alto API" should be its own management profile type, or if it would be sufficient to have a "REST API" profile that could be re-used across multiple vendors. In reality, there are many ways to authenticate against a even a REST API, so what's required for such a profile in the long run might be more than just an "api token" string. Perhaps "REST API with static token" would be a suitable name?

Describe alternatives you've considered

The current solution is a workable alternative, but not a very good one.

Additional context

See #2613 for the original implementation.

@lunkwill42 lunkwill42 added enhancement seeddb discussion Requires developer feedback/discussion before implementation PaloAlto labels May 2, 2024
@lunkwill42
Copy link
Member Author

Really, all that we need to store for the time being is a "static API token" - it doesn't even have to be a REST-based API. How the token is used is entirely up to implementations that utilize such a profile.

@jorund1 jorund1 self-assigned this Jul 31, 2024
@jorund1
Copy link
Collaborator

jorund1 commented Aug 1, 2024

I'm working on fetching data from a Kea Control Agent's Rest API, so I'm also interested in storing Rest API configurations in a management profile. I'll have a look at this issue as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Requires developer feedback/discussion before implementation enhancement PaloAlto seeddb
Projects
None yet
Development

No branches or pull requests

2 participants