Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We need to organize the templates better #127

Open
hmpf opened this issue Sep 6, 2024 · 2 comments
Open

We need to organize the templates better #127

hmpf opened this issue Sep 6, 2024 · 2 comments
Labels
refactor Move stuff around without breaking anything

Comments

@hmpf
Copy link
Collaborator

hmpf commented Sep 6, 2024

We should use namespacing so that template fragments for modals are in one directory, templates for incident columns in another etc.

@hmpf hmpf added the refactor Move stuff around without breaking anything label Sep 6, 2024
@hmpf
Copy link
Collaborator Author

hmpf commented Sep 6, 2024

I was thinking:

incidents/
|- list/
|  |- modals/..
|  |- columns/..
|  \- incident_list.html
\ detail/
   |- modals/..
   \- incident_detail.html

.. considering that bulk modal and single incident modals need different texts thanks to English plural vs. singular nouns in help texts and titles etc.

@elfjes
Copy link
Contributor

elfjes commented Sep 6, 2024

That sounds good to me. I don't have any strong feelings towards how to organize, but some improved organization sounds good. We can match whatever organization will be settled on :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Move stuff around without breaking anything
Projects
Status: 🔖 Ready
Development

No branches or pull requests

2 participants